Remove bridgelessEnabled from DefaultNewArchitectureEntryPoint - #58415
Open
christophpurrer wants to merge 1 commit into
Open
Remove bridgelessEnabled from DefaultNewArchitectureEntryPoint#58415christophpurrer wants to merge 1 commit into
bridgelessEnabled from DefaultNewArchitectureEntryPoint#58415christophpurrer wants to merge 1 commit into
Conversation
Summary: Bridgeless is the only supported mode in the New Architecture, so the `bridgelessEnabled` flag on `DefaultNewArchitectureEntryPoint` was dead configuration: every `load(...)` path passed `true`, and `isConfigurationValid` raised an error when it was `false`. The entry point advertised a toggle that could only ever hold the one value that is already mandatory. This removes that surface from `ReactAndroid`: - Removed the public `bridgelessEnabled` getter and its backing field. - Removed the deprecated three-argument `load(turboModulesEnabled, fabricEnabled, bridgelessEnabled)` overload. Its implementation body moved into the two-argument overload, since dropping the parameter alone would have collided with the existing `load(Boolean, Boolean)` signature. - Removed the `bridgelessEnabled` parameter from `isConfigurationValid`, reducing the guard to `!turboModulesEnabled || !fabricEnabled` and shortening the resulting error message. - `loadWithFeatureFlags` no longer reads `enableBridgelessArchitecture()`. Behavior note: `loadWithFeatureFlags` previously raised an error when a feature flags provider returned `enableBridgelessArchitecture() == false`. That check is gone. It was unreachable in practice because bridgeless is not optional, but it is a removed validation rather than a pure no-op cleanup. Bridgeless remains unconditionally enabled. Callers using the no-argument `load()` are unaffected. The regenerated `ReactAndroid.api` drops exactly `getBridgelessEnabled ()Z`, `load (ZZZ)V`, and `load$default (ZZZILjava/lang/Object;)V`. The equivalent iOS cleanup is intentionally left to a follow-up change. Changelog: [Android][Breaking] - Remove `DefaultNewArchitectureEntryPoint.bridgelessEnabled` and the deprecated three-argument `load(turboModulesEnabled, fabricEnabled, bridgelessEnabled)` overload; bridgeless is always enabled in the New Architecture Differential Revision: D116317210
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116317210. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Bridgeless is the only supported mode in the New Architecture, so the
bridgelessEnabledflag onDefaultNewArchitectureEntryPointwas deadconfiguration: every
load(...)path passedtrue, andisConfigurationValidraised an error when it was
false. The entry point advertised a toggle thatcould only ever hold the one value that is already mandatory.
This removes that surface from
ReactAndroid:bridgelessEnabledgetter and its backing field.load(turboModulesEnabled, fabricEnabled, bridgelessEnabled)overload. Itsimplementation body moved into the two-argument overload, since dropping the
parameter alone would have collided with the existing
load(Boolean, Boolean)signature.bridgelessEnabledparameter fromisConfigurationValid,reducing the guard to
!turboModulesEnabled || !fabricEnabledand shorteningthe resulting error message.
loadWithFeatureFlagsno longer readsenableBridgelessArchitecture().Behavior note:
loadWithFeatureFlagspreviously raised an error when a featureflags provider returned
enableBridgelessArchitecture() == false. That check isgone. It was unreachable in practice because bridgeless is not optional, but it
is a removed validation rather than a pure no-op cleanup.
Bridgeless remains unconditionally enabled. Callers using the no-argument
load()are unaffected. The regeneratedReactAndroid.apidrops exactlygetBridgelessEnabled ()Z,load (ZZZ)V, andload$default (ZZZILjava/lang/Object;)V.The equivalent iOS cleanup is intentionally left to a follow-up change.
Changelog:
[Android][Breaking] - Remove
DefaultNewArchitectureEntryPoint.bridgelessEnabledand the deprecated three-argumentload(turboModulesEnabled, fabricEnabled, bridgelessEnabled)overload; bridgeless is always enabled in the New ArchitectureDifferential Revision: D116317210