Skip to content

V2 -- Remove --open call on npm start #46

Description

@sthzg

As brought up in generator-react-webpack #266

V2

  • remove the --open call on npm start
  • log dev server address to console after the inital webpack build is ready

@weblogixx should I tackle this?

Activity

  1. weblogixx commented on Aug 11, 2016

    @weblogixx
    Member

    Hi @sthzg, sure just go ahead.

  2. changed the title [-]Remove --open call on npm start[/-] [+]V2 -- Remove --open call on npm start[/+] on Aug 11, 2016
  3. sthzg commented on Aug 11, 2016

    @sthzg
    MemberAuthor

    @weblogixx I've split this issue out in two:

    #46 => V1
    #47 => V2.

    In the V2 version npm start directly invokes the webpack-dev-server cli, so there is no way that I know of to listen for the end of the (first) compilation to print a message to the console afterwards. Webpack however prints it by default on the very top (which after bundling is in the scrollback).

    If this isn't good enough I don't see another way than bootstrapping the webpack-dev-server in a script file so that we can register a listener to when the first compilation is done (as a reference the implementation in the V1 branch).

  4. weblogixx commented on Aug 11, 2016

    @weblogixx
    Member

    Yes, there seems to be no way to do this with the command line currently :(. Have to think about that.

  5. sthzg commented on Aug 13, 2016

    @sthzg
    MemberAuthor

    Would there be something speaking against a devserver.js script in the root dir (like it has been in V3 with server.js)? After all, it seems to be just a small wrapper around the CLI, or am I missing something?

  6. weblogixx commented on Aug 13, 2016

    @weblogixx
    Member

    The only reason I removed it was that there is one file less and you can parse cli args into the launcher directly.

  7. added this to the 2.0 milestone on Sep 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions