feat: export missing types from standard-navigator#4
Merged
Conversation
satya164
reviewed
Jun 1, 2026
| }; | ||
|
|
||
| type NavigatorEventMapBase = Record< | ||
| export type NavigatorEventMapBase = Record< |
Member
There was a problem hiding this comment.
I'm not sure this should be exported. This one is just for the generic. Consumers should define the event map they support, which they should be able to use for all of their code.
Member
There was a problem hiding this comment.
Removing this export for now. I see the value for implementors, but from React Navigation, my experience has been that people overuse such types where they should specify a correct type. So for now, I'd avoid exporting it. It's quite tiny so I think it shouldn't be a problem to duplicate for implementors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.