fix(android): support numbersInnerTextColor in config plugin - #1052
Open
giaBaoJS wants to merge 1 commit into
Open
fix(android): support numbersInnerTextColor in config plugin#1052giaBaoJS wants to merge 1 commit into
giaBaoJS wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1029.
numbersInnerTextColorto the framework'sandroid:numbersInnerTextColorattribute.styles.xml, lightcolors.xml, and darkcolors.xmloutput.Test Plan
What's required for testing (prerequisites)?
yarn install --immutable.What are the steps to reproduce (after prerequisites)?
yarn test plugin/src/__tests__/withDateTimePickerStyles.test.js --runInBand— 2 tests passed.yarn test --runInBand— 24 tests passed across 4 suites.yarn lint— passed with 0 errors (22 existing warnings).yarn eslint plugin/src/__tests__/withDateTimePickerStyles.test.js— passed.yarn plugin:build— passed.yarn prettier --check plugin/src/withDateTimePickerStyles.ts plugin/src/__tests__/withDateTimePickerStyles.test.js docs/android-styling.md— passed.yarn pack --dry-run— passed.Regression evidence:
android.styleswithInvalid attribute name: numbersInnerTextColor.colors.xmlvalue, confirming the XML assertions are active.yarn flowcannot execute on this ARM64 macOS host because the installed macOS Flow binary is x86_64. Running the Linux ARM64 binary in a container also exposes the existing.flowconfig/dependency version mismatch (^0.217.0vs0.278.0) and existing Flow errors. The plugin TypeScript build passes.Compatibility
Checklist
README.mdexample/App.js)