fix: getBuildSettings picking up wrong target#2801
Open
divyanshu-patil wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a project contains multiple build targets where a non-app target (such as a
.frameworktarget) appears before the.apptarget in the Xcode build settingsoutput, the CLI incorrectly installs and launches the framework instead of the app.
Root Cause
The code correctly filters
applicationTargetsto only include.apptargets,but then uses the index from the filtered array to look up build settings in the
original unfiltered
settingsarray:For example, given the following build settings output from
xcodebuild -showBuildSettings -json:After filtering by
WRAPPER_EXTENSION === 'app':applicationTargets.indexOf("Mattermost")returns0, butsettings[0]isReact-Core, notMattermost, so the wrong build settings are returned.applicationTargetsafter filtering is["Mattermost"], soapplicationTargets.indexOf("Mattermost")returns0. Howeversettings[0]points to
React-Core, notMattermost, causing the wrong build settings tobe returned.
Fix
Look up the correct entry directly from the
settingsarray by target nameinstead of relying on the filtered index:
Additionally, improved the default target selection to prefer a target whose
name matches the scheme before falling back to the first available target:
Test Plan
at least one
.frameworktarget appearing before the.apptarget in thebuild output (e.g. Mattermost Mobile).
npm run iosorreact-native run-ios..apptarget is installed and launched on the simulatorinstead of the
.frameworktarget.Before fix: CLI installs
React.frameworkand attempts to launchorg.cocoapods.React, resulting in:After fix: CLI correctly installs and launches the
.apptarget.Checklist
local
react-nativecheckout.