Skip to content

revert: allow util deep imports#23

Closed
zombieJ wants to merge 2 commits into
mainfrom
codex/revert-util-deep-imports
Closed

revert: allow util deep imports#23
zombieJ wants to merge 2 commits into
mainfrom
codex/revert-util-deep-imports

Conversation

@zombieJ

@zombieJ zombieJ commented Jul 10, 2026

Copy link
Copy Markdown
Member

Reverts #22.

The deep-import restriction is intentional. Missing root exports should be fixed in @rc-component/util instead.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zombieJ, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0f0761d0-afc7-471e-b42f-0f07aa953ff0

📥 Commits

Reviewing files that changed from the base of the PR and between e6576d9 and 722bc99.

📒 Files selected for processing (1)
  • src/index.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/revert-util-deep-imports

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zombieJ zombieJ closed this Jul 10, 2026
@zombieJ zombieJ deleted the codex/revert-util-deep-imports branch July 10, 2026 09:20

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes exceptions for @rc-component/util and rc-util from the restricted package directory imports in src/index.ts. The reviewer notes that this is a breaking change because it re-enables restrictions on deep imports. They warn that automated release tools might incorrectly publish this as a patch or minor version due to the commit message, and advise bumping the major version appropriately.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

I am having trouble creating individual review comments. Click here to see my feedback.

src/index.ts (13-16)

high

Removing these exceptions for @rc-component/util (and similarly for rc-util on lines 21-24) re-enables the restriction on deep imports. This is a breaking change for consumers of this plugin who may rely on these deep imports.

According to Semantic Versioning (SemVer), breaking changes should result in a major version increase (e.g., 2.x.y -> 3.0.0).

The commit message revert: ... might be treated as a patch by automated release tools following Conventional Commits, which could lead to publishing a breaking change under a minor or patch version. Please ensure the package version is bumped appropriately to reflect this breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant