Skip to content

RDKCOM-5595: RDKBDEV-3450 The CM is not updated with DNS Name (Option15), instead utopia.net is displayed in LAN side provisioning. - #341

Open
aprasad-97 wants to merge 2 commits into
rdkcentral:developfrom
aprasad-97:RDKBDEV-3450
Open

RDKCOM-5595: RDKBDEV-3450 The CM is not updated with DNS Name (Option15), instead utopia.net is displayed in LAN side provisioning.#341
aprasad-97 wants to merge 2 commits into
rdkcentral:developfrom
aprasad-97:RDKBDEV-3450

Conversation

@aprasad-97

@aprasad-97 aprasad-97 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Reason for change: Added provisioning to fetch the DHCPv4 Option 15 (Domain Name) value via udhcpc and forward it to the WAN Manager. The WAN Manager then sets the corresponding sysevent, enabling dnsmasq to propagate the domain name to LAN clients.

Test Procedure:

  1. Configure in DHCP Policy, DHCP option-15 with dns name in CNR. (eg: qacafe)
  2. Reboot CM.
  3. Wait a few minutes until eRouter0 provisioning will finish.
  4. Check that /var/dnsmasq.conf is updated with the DNS name
  5. Check the DHCP provisioning packets in the LAN. The DHCP offer packet in the LAN should display correct domain name in option-15. Instead, it currently displays utopia.net .

Risks: Low
Priority: P1

Copilot AI review requested due to automatic review settings June 10, 2026 09:22
@aprasad-97
aprasad-97 requested review from a team as code owners June 10, 2026 09:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds DHCP domain-name propagation into the udhcpc service’s data path so it can be stored and logged alongside existing DHCP lease fields.

Changes:

  • Introduces a DHCP_DOMAIN_NAME environment key.
  • Logs the domain value in handle_wan.
  • Reads the DHCP domain from the environment into ipc_dhcpv4_data_t.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/service_udhcpc/service_udhcpc.c
Comment thread source/service_udhcpc/service_udhcpc.c
@pradeeptakdas pradeeptakdas changed the title RDKBDEV-3450 - The CM is not updated with DNS Name (Option15), instead utopia.net is displayed in LAN side provisioning. RDKCOM-5595: RDKBDEV-3450 The CM is not updated with DNS Name (Option15), instead utopia.net is displayed in LAN side provisioning. Jun 10, 2026
@AkhilaReddyK7 AkhilaReddyK7 added the community-contribution Contribution from community label Jun 15, 2026
Copilot AI review requested due to automatic review settings June 17, 2026 08:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

…d utopia.net is displayed in LAN side provisioning.

Reason for change: Added provisioning to fetch the DHCPv4 Option 15 (Domain Name) value via udhcpc and forward it to the WAN Manager. The WAN Manager then sets the corresponding sysevent, enabling dnsmasq to propagate the domain name to LAN clients.

Risks: Low

Signed-off-by: Aiswarya Prasad <aprasad@maxlinear.com>
Copilot AI review requested due to automatic review settings July 16, 2026 17:30
@tinaelizabeth84

Copy link
Copy Markdown

@aprasad-97 Please address the coPilot review comments. If they are not valid please provide an explanation and resolve them. Thanks

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread source/service_udhcpc/service_udhcpc.c
@aprasad-97

Copy link
Copy Markdown
Contributor Author

@aprasad-97 Please address the coPilot review comments. If they are not valid please provide an explanation and resolve them. Thanks

Adressed. @tinaelizabeth84

Copilot AI review requested due to automatic review settings July 31, 2026 16:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

source/service_udhcpc/service_udhcpc.c:1345

  • The newly added Option 15 (domain name) extraction/forwarding path isn’t covered by the existing service_udhcpc unit tests. Given this logic directly affects what WAN Manager (and ultimately dnsmasq/LAN DHCP offers) will advertise, it should be verified with at least one test that sets the domain env var and checks that get_and_fill_env_data() populates dhcpv4_data->domain for bound/renew states (and leaves it empty when unset).
        /** Domain name */
        if ((env = getenv(DHCP_DOMAIN_NAME)) != NULL)
        {
            safec_rc = strcpy_s(dhcpv4_data->domain, sizeof(dhcpv4_data->domain), env); // CID 187457: Buffer not null terminated (BUFFER_SIZE)
            ERR_CHK(safec_rc);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contribution from community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants