RDKCOM-5595: RDKBDEV-3450 The CM is not updated with DNS Name (Option15), instead utopia.net is displayed in LAN side provisioning. - #341
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds DHCP domain-name propagation into the udhcpc service’s data path so it can be stored and logged alongside existing DHCP lease fields.
Changes:
- Introduces a
DHCP_DOMAIN_NAMEenvironment key. - Logs the domain value in
handle_wan. - Reads the DHCP domain from the environment into
ipc_dhcpv4_data_t.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
503d9cb to
43c3895
Compare
43c3895 to
4ff5949
Compare
…d utopia.net is displayed in LAN side provisioning. Reason for change: Added provisioning to fetch the DHCPv4 Option 15 (Domain Name) value via udhcpc and forward it to the WAN Manager. The WAN Manager then sets the corresponding sysevent, enabling dnsmasq to propagate the domain name to LAN clients. Risks: Low Signed-off-by: Aiswarya Prasad <aprasad@maxlinear.com>
4ff5949 to
099f300
Compare
|
@aprasad-97 Please address the coPilot review comments. If they are not valid please provide an explanation and resolve them. Thanks |
Adressed. @tinaelizabeth84 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
source/service_udhcpc/service_udhcpc.c:1345
- The newly added Option 15 (domain name) extraction/forwarding path isn’t covered by the existing
service_udhcpcunit tests. Given this logic directly affects what WAN Manager (and ultimately dnsmasq/LAN DHCP offers) will advertise, it should be verified with at least one test that sets thedomainenv var and checks thatget_and_fill_env_data()populatesdhcpv4_data->domainforbound/renewstates (and leaves it empty when unset).
/** Domain name */
if ((env = getenv(DHCP_DOMAIN_NAME)) != NULL)
{
safec_rc = strcpy_s(dhcpv4_data->domain, sizeof(dhcpv4_data->domain), env); // CID 187457: Buffer not null terminated (BUFFER_SIZE)
ERR_CHK(safec_rc);
Reason for change: Added provisioning to fetch the DHCPv4 Option 15 (Domain Name) value via udhcpc and forward it to the WAN Manager. The WAN Manager then sets the corresponding sysevent, enabling dnsmasq to propagate the domain name to LAN clients.
Test Procedure:
Risks: Low
Priority: P1