chore(server): remove the resources_config_path boot loader flow#1767
chore(server): remove the resources_config_path boot loader flow#1767rohilsurana wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1ee7ba3 to
043bb7e
Compare
… removed boot loader
Coverage Report for CI Build 29568253588Coverage decreased (-0.02%) to 46.092%Details
Uncovered Changes
Coverage Regressions17 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
Stacked on #1766 (dead-cache removal); rebase onto main once that merges.
What
Removes the
app.resources_config_pathboot loader end to end. Custom permissions and roleoverrides are now managed through the reconcile flow (the
PermissionandRolekinds),so the server no longer reads a resource config file at startup.
cmd/serve.go: drop the resource blob load and theSchemaConfigRepositorywiring.internal/bootstrap: drop theFileService(schemaConfig) dependency.MigrateSchemanow re-applies the base schema merged with the permissions already in the DB (via
AppendSchema, which already preserves them) instead of reading a config file;MigrateRolesno longer creates config-defined custom roles (reconcile owns them); andBuiltinPermissions(the permission delete-guard) reports only base-schema permissions.pkg/server/config.go: remove theresources_config_path/resources_config_path_secretfields.
internal/store/blob/schema_repository.go: removed (no longer used).config/sample.config.yaml: drop the sample entries.Existing custom permissions survive across boots because they live in the database and
AppendSchemamerges them back into the schema. Existing role overrides survive becauseMigrateRolesis skip-if-exists. So on a server that has already migrated, this is a no-op;on one that has not, it would stop seeding from the config — which is exactly why it is gated.
Why this is gated
resources_config_path.Per the RFC (docs/rfcs/0001-declarative-reconcile.md), the loader is deprecated for two
minor versions before removal. That window started at v0.110.0, so removal lands ~v0.112.0.
are owned there, and dropping
resources_config_pathfrom their own configs.Build,
go build ./..., and tests forinternal/bootstrap,pkg/server,core/resource,internal/api/v1beta1connect, andcmdall pass; lint clean.