feat(radio): add size variants, orientation prop, and fix CSS issues#739
feat(radio): add size variants, orientation prop, and fix CSS issues#739rohanchkrabrty wants to merge 1 commit intomainfrom
Conversation
#630) - Add size prop (small | large) using CVA, matching Switch component pattern - Add orientation prop (vertical | horizontal) to Radio.Group for layout control - Fix indicator dot using --rs-radius-3 (border-radius token) for width/height, replaced with --rs-space-2 (spacing token) for correct semantic usage - Add CSS comments clarifying display property intent on .group and .radioitem - Scale indicator dot proportionally for each size variant - Add tests for size variants and orientation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 50 minutes and 22 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
sizeprop (small|large) to Radio using CVA, following the same pattern as the Switch component. Default islarge(preserving current 16px size). Small variant uses--rs-space-4(12px).orientationprop (vertical|horizontal) toRadio.Groupfor controlling layout direction. Default isvertical. Implemented as a custom Apsara feature since Base UI's RadioGroup does not natively support orientation.--rs-radius-3(a border-radius token) with--rs-space-2(a spacing token) for the indicator dot width/height, fixing semantic token misuse..radioto.group, add clarifying CSS comments for the display property usage on.group(flex for layout) and.radioitem(inline-flex for centering indicator), and remove fixed dimensions from.radioitembase class (moved to size variants).--rs-space-1.Closes #630
Test plan
tsc --noEmit)🤖 Generated with Claude Code