Require core ^0.9 rather than accepting 0.8 alongside - #42
Merged
Conversation
core 0.9.0 is published, and the family moves to it together: -testo pins the skip counters its characterizations assert, and -names must match or it is once again uninstallable beside its own adapters. An adapter that accepted both engines is the shape that caused that. No code changes: the excessive-discard warning reads the engine's discard counter, which no longer carries an environmental skip.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Warning Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #41, now that
rasuvaeff/property-testing-core0.9.0 is published.^0.8 || ^0.9narrows to^0.9.The transitional range existed only so #41 could merge before the core release. Keeping it would leave the family split:
-testorequires^0.9(its give-up characterizations assert the new skip counters), and-namesfollows in the same wave — an adapter accepting both engines is exactly the shape that made-namesuninstallable beside its own adapters (property-testing-names#24).No code changes.
composer buildgreen against core v0.9.0 from Packagist: 83 tests, 2969 assertions. The 0.7.1 section is still untagged, so this amends it rather than opening a new version.