Get model from family, if '--platform' is missing#346
Open
tzstoyanov wants to merge 2 commits into
Open
Conversation
If the user does not use the `--platform` parameter to specify the target platform for uf2 convert command, get the model from the target family. The current logic tries to guess the platform by analyzing the target binary file. It works OK in most regular cases, but fails in some weird cases where the image is not located at absolute FLASH_START offset. Signed-off-by: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
|
Please do not submit against |
will-v-pi
reviewed
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user does not use the
--platformparameter to specify the target platform for uf2 convert command, get the model from the target family. The current logic tries to guess the platform by analyzing the target binary file. It works OK in most regular cases, but fails in some weird cases where the image is not located at absolute FLASH_START offset.fixes #339