Better fix for elf squashing#341
Open
will-v-pi wants to merge 1 commit into
Open
Conversation
Don't squash into occupied areas, and don't squash metadata blocks This reverts commit 0d16086
lurch
reviewed
Jul 14, 2026
kilograham
reviewed
Jul 17, 2026
| } | ||
|
|
||
|
|
||
| std::vector<std::unique_ptr<block>> get_all_blocks(elf_file *elf, std::unique_ptr<block> &first_block) { |
Contributor
There was a problem hiding this comment.
probably worth doing what the bootrom does which is to detect cycles (can either use the. simple check the bootrom does which is to assume blocks are in order, or just use a set!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't squash into occupied areas, and don't squash metadata blocks
This reverts commit 0d16086 which was an incomplete fix for this