Fix macOS native tabs in unified titlebar - #1908
Open
fguisso wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
NativeTab mode added a separate tab row below the macOS titlebar. With macOS liquid glass, the traffic lights, tabs, and terminal content were composed as separate surfaces, which created gaps and duplicated rounded corners.
Fix
The macOS window now repositions the native tab accessory with AppKit constraints and keeps those constraints updated when the titlebar changes. The integrated titlebar receives a matching glass view and follows the terminal background and opacity in active and inactive states. This behavior is limited to the macOS native tab and unified titlebar path.
Validation
cargo +1.96.1 build -p rioterm --features wgpucargo +1.96.1 test -p rio-window --libcargo +1.96.1 clippy -p rio-window --lib -- -D warningscargo +1.96.1 fmt --all -- --check