Skip to content

fix(ci): Make the vcvars64.bat path dynamic#680

Merged
rabbitstack merged 1 commit into
masterfrom
change-visual-studio-version
Jun 18, 2026
Merged

fix(ci): Make the vcvars64.bat path dynamic#680
rabbitstack merged 1 commit into
masterfrom
change-visual-studio-version

Conversation

@rabbitstack

@rabbitstack rabbitstack commented Jun 18, 2026

Copy link
Copy Markdown
Owner

What is the purpose of this PR / why it is needed?

Replace the hardcoded VS path with vswhere.exe, which is always available on GitHub runners and resolves the correct installation regardless of edition or version.

What type of change does this PR introduce?


Uncomment one or more /kind <> lines:

/kind feature (non-breaking change which adds functionality)

/kind bug-fix (non-breaking change which fixes an issue)

/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)

/kind breaking (fix or feature that would cause existing functionality to not work as expected

/kind cleanup

/kind improvement

/kind design

/kind documentation

/kind other (change that doesn't pertain to any of the above categories)

Any specific area of the project related to this PR?


Uncomment one or more /area <> lines:

/area instrumentation

/area telemetry

/area rule-engine

/area filters

/area yara

/area event

/area captures

/area alertsenders

/area outputs

/area rules

/area filaments

/area config

/area cli

/area tests

/area ci

/area build

/area docs

/area deps

/area evasion

/area other

Special notes for the reviewer


Does this PR introduce a user-facing change?


@rabbitstack rabbitstack force-pushed the change-visual-studio-version branch from b922170 to 33763da Compare June 18, 2026 16:49
@rabbitstack rabbitstack changed the title fix(ci): Change Visual Studio version to 2026 fix(ci): Make the vcvars64.bat path dynamic Jun 18, 2026
@rabbitstack rabbitstack force-pushed the change-visual-studio-version branch from 33763da to bf6d462 Compare June 18, 2026 17:18
Replace the hardcoded VS path with vswhere.exe, which is always available on GitHub runners and resolves the correct installation regardless of edition or version.
@rabbitstack rabbitstack merged commit 9812695 into master Jun 18, 2026
11 checks passed
@rabbitstack rabbitstack deleted the change-visual-studio-version branch June 18, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant