Rename paste diagnostics key so the local sanitizer stops blanking it

[r3dbars]

Why

The dictation paste-confirmation diagnostics key target_text_observable is a pure boolean, but it showed up as [redacted-sensitive-value] in local events.jsonl: LocalObservabilityPayloadSanitizer drops any context key matching PayloadSanitizationCore.baseSensitiveKeyFragments, and the key name contains the fragment text. That blinded a real investigation into dictation_paste_confirmation_diagnostics events.

Product Impact

• Affects: dictation
• Lane: dictation reliability
• Why this matters: paste-confirmation failures can only be debugged from the local event log; a redacted boolean removes the one signal that says whether the target's AX value was even observable.

What changed

• Renamed the key to target_value_observable (it reports whether kAXValueAttribute was readable, so the new name is also more accurate) in both emit sites in Sources/Support/ClipboardRestoringTextPaster.swift: the real FocusedTextPasteConfirmation.diagnosticsContext(...) and the fallback literal dict on the unconfirmed-paste path.
• Added a short comment stating the constraint: diagnostics keys must avoid PayloadSanitizationCore sensitive fragments or the local sanitizer blanks their values.
• Updated the SyntheticPasteTargetAdapter test fake to match, and added a regression suite that drives a real unconfirmed paste, then asserts every emitted diagnostics key passes the local sanitizer's shouldDrop predicate and survives an end-to-end LocalObservabilityPayloadSanitizer.sanitize unredacted.

Rename over a safe-key exemption: the local sanitizer has no exemption mechanism today, and adding one for a single boolean is more machinery than the rename.

How I checked it

• scripts/dev/agent-preflight.sh
• Selected checks from .agents/test-matrix.yml for the files changed (python3 scripts/dev/check-build-source-lists.py, bash run-slow-pasteback-smoke.sh — both pass)
• bash build.sh --no-open
• bash run-tests.sh (12215 tests, all pass, new regression suite confirmed running)
• Performance budget passed (bash build.sh --no-open bundle gate)
• bash run-integration-smoke.sh if I touched Sources/Meeting/ or Sources/TranscriptedCore/ — not touched
• swift test if I touched Package.swift, Sources/TranscriptedCore/, or the public core seam — not touched
• Manual check: repo-wide grep confirms no remaining reference to the old key outside the regression comment

Risk Review

• Privacy / local-first behavior reviewed — the event is local-only (dictation_paste_confirmation_diagnostics appears in no Sentry allowlist and no analytics PSV); the new key clears all three sanitizers' fragment lists, including Sentry's extra context/identifier fragments
• Storage path or migration impact reviewed — none
• Public-facing copy stays concrete and matches current product scope — no copy changes
• Release/update impact reviewed — none
• Agent PRs link the issue/workpad and stay draft until human review
• UI changes include sanitized .agent-review/visuals/ evidence — no UI changes
• No private transcripts, audio, tokens, personal paths, or customer data are included

Notes

Only pastes logged after a restart on the new build carry the renamed key; historical events.jsonl lines keep the redacted marker, so split any log analysis at the deploy date.

Agent handoff

COORD_DONE: GREEN | PR URL below | renamed target_text_observable → target_value_observable + regression suite | none | none | build.sh, run-tests.sh, check-build-source-lists.py, run-slow-pasteback-smoke.sh | human review + merge

🤖 Generated with Claude Code