Recover saved meetings stuck in speaker review - #1696
Draft
r3dbars wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1681.
Supersedes #1693. That draft allowed same-ID request and stale-finalizer races; this branch replaces it with exact review-owner fencing.
What failed
The sanitized evidence proves the meeting Markdown, retained system audio, and speaker clips were saved before speaker-naming finalization failed to resolve stable ID
13D4DF54-AEC5-434D-8E44-C375E2F87473. It does not prove the exact filesystem trigger because the sanitized Markdown is shorter than the historical UTF-8 prefix boundary. The deterministic reproduction therefore reconstructs the stale expected-path / renamed canonical transcript condition with the evidence ID and a UTF-8 boundary case.Recovery
Automated proof on
4ad639c9Green:
bash build-deps.sh --forcebash build.sh --no-open— signed app, 1305.9 ms launch smokebash run-integration-smoke.shswift test— full TranscriptedCore package suite passedbash run-tests.sh --filter RecentCaptureScanners— 134/134codex review --base origin/main— clean after fixing both reported racesNot green:
bash run-tests.shcompleted with 12,190/12,195, five failures. Re-running the binary/wrapper to isolate names aborts or exits before printing failure lines. The changed RecentCapture suite passes alone. This is still a red required gate until the five failures are identified; do not merge on this receipt alone.Manual proof still required
Automated tests do not prove the real 94-minute system-only import, installed-app UI state, retained-audio discovery, or live speaker-sample playback.
Before merge, dogfood an affected or disposable retained-audio meeting and verify:
This PR is draft because the full fast-test gate and live affected-artifact proof remain open.