Simplified heat sliders - households - #4775
Open
jort-wolda wants to merge 7 commits into
Open
Conversation
Insulation sliders still to be done
Member
|
Ready for final review @mabijkerk. |
3 tasks
mabijkerk
reviewed
Aug 19, 2026
| @@ -182,12 +180,9 @@ en: | |||
| title: Heat demand & insulation | |||
Member
There was a problem hiding this comment.
We need to update these to be in line with the buildings as well, so refer to "Insulation" etc.
mabijkerk
reviewed
Aug 19, 2026
| insulation_terraced_houses: "Typical heat demand terraced houses" | ||
| insulation_semi_detached_houses: "Typical heat demand semi-detached houses" | ||
| insulation_detached_houses: "Typical heat demand detached houses" | ||
| housing_stock_number_of_residences: "Number of new residences" |
Member
There was a problem hiding this comment.
These come across as quite long:
I would stay closer to those for Buildings, so something like: Construction, Construction per type, Demolition per construction period - or simply Demolition should be enough since the 'per period' is implied?
mabijkerk
reviewed
Aug 19, 2026
| price_dependent: "willingness-to-pay" | ||
| temperature_dependent: "temperature" | ||
| per_residence_space_heating: "%" | ||
| households_insulation: "%" |
Member
There was a problem hiding this comment.
For Buildings, this says "Change". This needs to be aligned:
mabijkerk
reviewed
Aug 19, 2026
| households_number_of_semi_detached_houses_1965_1984: | ||
| title: 1965 - 1984 | ||
| description: | | ||
| This slider sets the number of new residences that are expected to be built. The sliders |
Member
There was a problem hiding this comment.
This sounds a bit weird. Why 'expected'?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR simplifies the input sliders for the housing stock and heat demand for houses.
Implemented changes
Related
Goes with pull requests:
Checklist