Add metastore read replica routing#6538
Draft
shuheiktgw wants to merge 5 commits into
Draft
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf5e1023f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
34a7657 to
3483232
Compare
4d1b1a1 to
8eb7176
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for routing read-only metastore requests to a PostgreSQL read replica.
The current scope is limited to metastore requests issued by searchers. Other read-only metastore call sites may also benefit from this later, but this PR keeps the initial coverage focused on the search path.
How It Works
metastore_read_replica_urialongside the existingmetastore_uri.metastore_urias the primary metastore and, when configured, resolvesmetastore_read_replica_urias a read-only PostgreSQL metastore client. The read replica client uses its own PostgreSQL connection pool, with the same pool settings as the regular PostgreSQL metastore configuration.ReadReplicaGrpcService, which contains the primary service and an optional read replica service. Incoming requests with theqw-use-read-replica: truegRPC metadata header are routed to the read replica service. If no read replica is configured, the wrapper falls back to the primary service.MetastoreReadServiceClient, which exposes only the read-only subset of metastore RPCs. The underlying gRPC client attaches theqw-use-read-replica: trueheader through an interceptor, so eligible searcher metastore requests are routed to the read replica when available.metastore_read_replica_uriis unset. This is safe because metastore nodes fall back to the primary service when no read replica service is configured.