Port block-list/pinocchio CLI to solana 3.x#94
Merged
Conversation
added 2 commits
July 1, 2026 20:14
Follow-up to the litesvm 0.13.1 / solana 3.x migration: the CLI was still on solana-2.x crates and no longer compiled against the ported block-list-client. - cli/Cargo.toml: bump solana-* 2.2 -> 3.0 (solana-sdk, solana-client, solana-clap-v3-utils, solana-cli-config, solana-logger, solana-remote-wallet) and add solana-commitment-config 3.0; bump spl-token-client 0.13 -> 0.18.0 (the release aligned with spl-token-2022 10.x used by the ported program/ test), spl-tlv-account-resolution 0.8.1 -> 0.11.0, spl-transfer-hook-interface 0.8.2 -> 2.0.0 - cli/src/main.rs: solana-sdk 3.0 dropped the commitment_config re-export, so import CommitmentConfig from solana-commitment-config. No other API or behaviour changes. Verified with `cargo check --manifest-path cli/Cargo.toml` (zero errors). The CLI is not built by CI, so this is validated locally.
The block-list/pinocchio project ships a `cli/` host binary that no CI workflow built, so its client-facing code could break (e.g. against a dependency bump) without CI noticing. Build any project's `cli/` explicitly in build_and_test, after the program build/tests. libudev-dev is installed because hidapi (pulled in transitively by solana-remote-wallet) needs libudev at build time and the runner image does not ship the -dev package. The step is guarded on a `cli/` directory existing, so it only runs for projects that have one (currently just block-list).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the litesvm 0.13.1 / solana 3.x migration (#93). The
block-list/pinocchioCLI was still on solana-2.x crates and no longer compiled against the portedblock-list-client.Changes
cli/Cargo.toml: bumpsolana-*2.2→3.0(solana-sdk,solana-client,solana-clap-v3-utils,solana-cli-config,solana-logger,solana-remote-wallet) and addsolana-commitment-config = "3.0.0"; bumpspl-token-client 0.13→0.18.0(the release aligned with thespl-token-2022 10.xused by the ported program/test — 0.19.x diverges tospl-token-2022 ^11),spl-tlv-account-resolution 0.8.1→0.11.0,spl-transfer-hook-interface 0.8.2→2.0.0.cli/src/main.rs:solana-sdk 3.0no longer re-exportscommitment_config, so importCommitmentConfigfromsolana-commitment-config. No other API or behaviour changes — all other call sites compiled unchanged against the 3.x APIs.Verification
Validated with
cargo check --manifest-path cli/Cargo.toml(zero errors) against the merged client onmain. Note: no CI workflow builds this CLI, so it is verified by local compile only. Building the CLI also requireslibudev-devon the host (forsolana-remote-wallet'shidapi).🤖 Generated with Claude Code
Generated by Claude Code