chore: clean up POM after class-pruner moved to its own repo#1210
Merged
chore: clean up POM after class-pruner moved to its own repo#1210
class-pruner moved to its own repo#1210Conversation
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/049970c5-1f98-4062-a50b-725354938a84 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
chrjohn
May 4, 2026 17:42
View session
chrjohn
changed the title
class-pruner moved to its own repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
quickfixj-class-pruner-maven-pluginlives at https://github.com/quickfix-j/quickfixj-class-pruner-maven-plugin, the source directory and all Maven artefacts that existed solely to support building it locally can be removed.Changes
quickfixj-class-pruner-maven-plugin/— entire directory (Java source, tests, test resources, GitHub Actions workflow)pom.xml—<dependencyManagement>— remove 8 entries that were only consumed by the deleted module:maven-shared-utils,file-management,maven-core,maven-artifact,maven-compat,maven-plugin-testing-harness,plexus-utils,plexus-xml; plus their 4 version properties (maven-shared-utils.version,file-management.version,maven-plugin-testing-harness.version,maven-libs-version)pom.xml—<pluginManagement>— removemaven-invoker-plugin(was only used to run the class-pruner's integration tests)quickfixj-distribution/pom.xml— removequickfixj-class-pruner-maven-plugindependency; it is an independent project now and should not be bundled in the distributionquickfixj-messages-fix*/pom.xml— remove redundant<version>${class-pruner-plugin.version}</version>from each plugin invocation; the version is already pinned in root<pluginManagement>quickfixj-messages/readme.md— replace broken relative link to the deletedreadme.mdwith a link to the external GitHub repo