Add golden-file regression tests for FIX42, FIX44, FixLatest code generation#1202
Add golden-file regression tests for FIX42, FIX44, FixLatest code generation#1202
Conversation
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/75ce6f0f-805a-433f-94f2-f4a1744e2c24 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/75ce6f0f-805a-433f-94f2-f4a1744e2c24 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
|
@copilot please add a readme on what to do on a generator change. |
…ator changes Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/ba2b68dc-4d0c-457e-98ee-353d16aedb3c Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Added |
|
@copilot the generator has too verbose output. We don't need to log every single generated field, message and component. |
Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/55fa23a6-aa70-48b2-96c8-47249dd99eaf Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Fixed in commit |
…eration Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/edba83d6-845f-4fa6-95d0-2cf2df045ccd Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
…EADME Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/03df7b1c-1c63-4d94-bfea-4e66a437dfe6 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
|
@copilot the build fails with JDK8. Seems you picked up the wrong code generator... |
…ava 11+ Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/d15a5bb4-2a4a-416c-a354-b5ef3cc809d3 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Fixed in commit |
|
@copilot strange that it does not work with JDK 8. QFJ project is using JDK 8 and the same plugin, so it should work with JDK 8. |
… messages-fixlatest test deps Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/fa475a4c-0b96-4b81-8ce3-6fc3db515e84 Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Fixed in commit The fix pins Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot OrchestraGoldenFileTest.testFIXLatestGenerationMatchesGolden:62 NoClassDefFound javax/xml/bind/JAXBException |
…-api:2.3.1 test dep Agent-Logs-Url: https://github.com/quickfix-j/quickfixj/sessions/bb9e5d4f-4f27-4922-ba93-3f1cefd443fc Co-authored-by: chrjohn <6644028+chrjohn@users.noreply.github.com>
Fixed in commit |
OrchestraGoldenFileTest.javafromquickfixj-messages-alltoquickfixj-messages-fixlatestOrchestraFIXLatest.min.xml,golden/fixlatest/) frommessages-alltomessages-fixlatestquickfixj-messages-fixlatest/pom.xmlquickfixj-messages-all/pom.xmlsrc/test/resources/golden/README.mdtoquickfixj-messages-fixlatest(explains when and how to regenerate orchestra golden files)OrchestraGoldenFileTestto reference the new README locationAll changes in this PR
quickfixj-codegenerator: Silenced per-item debug logging inMessageCodeGeneratorto reduce noise during code generationquickfixj-messages-all: AddedminimiseOrchestra.xslandminimal-fix-latestMaven profile that transforms the fullOrchestraFIXLatest.xmlinto a trimmed fixture (OrchestraFIXLatest.min.xml) containing only the fields, components, groups, and messages exercised by the core module's tests — reducing CodeQL heap usagequickfixj-messages-fixlatest: AddedOrchestraGoldenFileTest— a golden-file regression test that runsCodeGeneratorJagainstOrchestraFIXLatest.min.xmland compares every generated.javafile byte-for-byte with committed golden filesquickfixj-messages-fixlatest: Added 66 golden.javafiles undersrc/test/resources/golden/fixlatest/(fields, messages, components, cracker, factory) as the baseline for the orchestra regression testquickfixj-messages-fixlatest: Addedsrc/test/resources/golden/README.mdexplaining when and how to regenerate the orchestra golden files