[CI-Nightly]: Validating the nightly Result with Previous Result #992
Open
abukhoy wants to merge 4 commits into
Open
[CI-Nightly]: Validating the nightly Result with Previous Result #992abukhoy wants to merge 4 commits into
abukhoy wants to merge 4 commits into
Conversation
Signed-off-by: Abukhoyer Shaik <abukhoye@qti.qualcomm.com>
Signed-off-by: Abukhoyer Shaik <abukhoye@qti.qualcomm.com>
Signed-off-by: Abukhoyer Shaik <abukhoye@qti.qualcomm.com>
Signed-off-by: Abukhoyer Shaik <abukhoye@qti.qualcomm.com>
quic-hemagnih
requested changes
May 20, 2026
| ], | ||
| "validation_configs": { | ||
| "default": { | ||
| "percentage_tolerance": 50.0, |
Contributor
There was a problem hiding this comment.
Can you please explain how these thresholds are decided?
| "meta-llama/Llama-3.2-11B-Vision-Instruct", | ||
| "meta-llama/Llama-3.2-90B-Vision-Instruct", | ||
| "allenai/Molmo-7B-D-0924", | ||
| "Qwen/Qwen3-VL-30B-A3B-Instruct", |
Contributor
There was a problem hiding this comment.
Why are we skipping QWEN3-VL models ?
| def _numeric_mad(previous_value: Any, current_value: Any) -> float | str: | ||
| previous_flat = _flatten_numeric_values(previous_value) | ||
| current_flat = _flatten_numeric_values(current_value) | ||
| common_length = min(len(previous_flat), len(current_flat)) |
Contributor
There was a problem hiding this comment.
I think we should also check if the lengths are different, consider a case when current_length is 200 but previous_length is 500, we won't be able to catch that, if mad for first 200 token is same for both the cases
| total_difference = sum(abs(current_flat[index] - previous_flat[index]) for index in range(common_length)) | ||
| return total_difference / common_length | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Please add doc strings for all the functions, you can use agent to do that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is created for validating/comparing the perf and tokens with the previously nightly run Results.