cpe: unbind fs optimizations - #1979
Open
hdonnay wants to merge 6 commits into
Open
Conversation
hdonnay
force-pushed
the
hack/cpe/unbindfs
branch
from
August 13, 2026 20:21
ce58963 to
df33810
Compare
hdonnay
force-pushed
the
hack/cpe/unbindfs
branch
4 times, most recently
from
August 20, 2026 18:36
f359a6e to
33843a1
Compare
alkmim
reviewed
Aug 21, 2026
hdonnay
force-pushed
the
hack/cpe/unbindfs
branch
from
August 21, 2026 21:35
33843a1 to
0dfe744
Compare
Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: Ie370751f04dea27303130efdecfaecb56a6a6964
This eliminates a slice allocation by inlining the "splitting" logic into the only place it's used. Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: I535c589ce0ec716b6edce53b0678477d6a6a6964
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: I5bf3f39e2302db5684d90903ffb645186a6a6964
Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: I089646b3afc8638fc305ddc0441078d06a6a6964
hdonnay
force-pushed
the
hack/cpe/unbindfs
branch
from
August 21, 2026 21:52
0dfe744 to
2858ac4
Compare
This reimplements `UnbindFS` with `UnmarshalFS`, then removes the dedicated benchmark and marks the former as deprecated. Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: I7d463973d062f4b352a3487372dadb036a6a6964
hdonnay
force-pushed
the
hack/cpe/unbindfs
branch
from
August 24, 2026 21:13
2858ac4 to
6d83d52
Compare
alkmim
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some memory profiling revealed that in large imports, this function is doing a lot of allocation just to do the unbinding (meaning the underlying
cpe.WFNvalue is not in that bookkeeping).These changes include:
The results locally: