Fix revealjs title author ORCID spacing#14354
Closed
jnkatz wants to merge 1 commit intoquarto-dev:mainfrom
Closed
Conversation
Collaborator
|
Thank you for the report ! This is indeed a space not correctly placed. I'll handle it from here - we prefer to have smoke-all test now , and we need changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes revealjs fancy title slides so authors without ORCID IDs do not render a trailing space after the author name.
The title slide partial had a literal separator space before the optional ORCID block. When
by-author.orcidwas unset, that separator remained as trailing whitespace in the generated author-name block. This moves the separator inside the ORCID conditional so it is only emitted when the ORCID link is emitted.Validation
</div>and does not contain trailing horizontal whitespace before that closing tag.git diff --check../configure.shsuccessfully after allowing Deno network access outside the local sandbox.DENO_DIR=aarch64 QUARTO_TESTS_NO_CONFIG=true QUARTO_TESTS_FORCE_NO_VENV=true ./run-tests.sh smoke/render/render-reveal.test.ts.The new
title-fancy-author.qmdregression test passed. Three existing tests in the same file failed in this local checkout because the fresh R test environment did not haveknitr/rmarkdowninstalled; those failures were unrelated to this title-slide change.Jonathan N. Katzis followed by a newline and</div>, with no trailing horizontal whitespace.