Fix inconsistencies in double factorization cost estimation#1366
Merged
Conversation
Double factorization uses different precisions for theta for the first and second factorizations, but the cost estimation function used the first precision for estimating the cost of the second factorization. This was corrected and tests updated to reflect the changed cost function.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request resolves a bug in the double factorization resource estimation where the variable br (representing bits of precision for rotation) was overwritten. Previously, the first value of br was incorrectly used to calculate the QROM output size (bo) before being overwritten with a value of 7 for the second state preparation. The fix splits br into br_first and br_second, ensuring br_second is defined and used correctly for bo. Test assertions have been updated to reflect the corrected resource estimates. As there are no review comments, I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #839. Double factorization uses different precisions for$\theta$ for the first and second factorizations (leading to differences in gate counts), but when estimating the cost of double factorization, the first precision is used for both factorizations. This was corrected and the tests updated to reflect the changed cost function.