Skip to content

Fix mypy errors in batch 2 part 3 (#1282) #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rosspeili wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −7
Open

Fix mypy errors in batch 2 part 3 (#1282) #1365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6aae789
Fix mypy errors in batch 2 part 3 (#1282)
rosspeili Jun 16, 2026
4c3108b
Use List from typing for spins annotation per review
rosspeili Jun 16, 2026
7279804
Use builtin list annotations in plane_wave_hamiltonian
rosspeili Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/openfermion/hamiltonians/plane_wave_hamiltonian.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# limitations under the License.
"""Construct Hamiltonians in plan wave basis and its dual in 3D."""

from typing import List, Tuple, Optional, Union
from typing import Tuple, Optional, Union

import numpy as np

Expand All @@ -26,7 +26,7 @@

def dual_basis_external_potential(
grid: Grid,
geometry: List[Tuple[str, Tuple[Union[int, float], Union[int, float], Union[int, float]]]],
geometry: list[Tuple[str, Tuple[Union[int, float], Union[int, float], Union[int, float]]]],
spinless: bool,
non_periodic: bool = False,
period_cutoff: Optional[float] = None,
Expand Down Expand Up @@ -56,6 +56,7 @@ def dual_basis_external_potential(
if non_periodic and period_cutoff is None:
period_cutoff = grid.volume_scale() ** (1.0 / grid.dimensions)
operator = None
spins: list[Optional[int]]
if spinless:
spins = [None]
else:
Expand Down Expand Up @@ -115,7 +116,7 @@ def filter_plane_wave_operator(

def plane_wave_external_potential(
grid: Grid,
geometry: List[Tuple[str, Tuple[Union[int, float], Union[int, float], Union[int, float]]]],
geometry: list[Tuple[str, Tuple[Union[int, float], Union[int, float], Union[int, float]]]],
spinless: bool,
e_cutoff: Optional[float] = None,
non_periodic: bool = False,
Expand Down Expand Up @@ -157,7 +158,7 @@ def plane_wave_external_potential(
def plane_wave_hamiltonian(
grid: Grid,
geometry: Optional[
List[Tuple[str, Tuple[Union[int, float], Union[int, float], Union[int, float]]]]
list[Tuple[str, Tuple[Union[int, float], Union[int, float], Union[int, float]]]]
] = None,
spinless: bool = False,
plane_wave: bool = True,
Expand Down Expand Up @@ -216,7 +217,7 @@ def plane_wave_hamiltonian(
def jordan_wigner_dual_basis_hamiltonian(
grid: Grid,
geometry: Optional[
List[Tuple[str, Tuple[Union[int, float], Union[int, float], Union[int, float]]]]
list[Tuple[str, Tuple[Union[int, float], Union[int, float], Union[int, float]]]]
] = None,
spinless: bool = False,
include_constant: bool = False,
Expand Down
4 changes: 2 additions & 2 deletions src/openfermion/resource_estimates/surface_code_compilation/physical_costing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
class MagicStateFactory:
details: str
physical_qubit_footprint: int
rounds: int
failure_rate: int
rounds: float
failure_rate: float


@dataclasses.dataclass(frozen=True, unsafe_hash=True)
Expand Down
Loading