feat: use OutputTable with --no-headers support in all list commands#112
Open
Davidonium wants to merge 5 commits intomainfrom
Open
feat: use OutputTable with --no-headers support in all list commands#112Davidonium wants to merge 5 commits intomainfrom
Davidonium wants to merge 5 commits intomainfrom
Conversation
JustAwesomeGuy
previously approved these changes
Apr 10, 2026
JustAwesomeGuy
left a comment
JustAwesomeGuy
left a comment
There was a problem hiding this comment.
Lgtm! If you rather remove the legacy PrintText in other MR feel free to merge.
…-table-pattern-in-list-cmds
Furthermore, removed the PrintText option in ListCmd to avoid inconsistencies. Also updated AGENTS.md with up to date examples.
Davidonium
commented
Apr 10, 2026
| Short string | ||
| Long string | ||
| Example string | ||
| Args cobra.PositionalArgs // optional; defaults to cobra.NoArgs |
Collaborator
Author
There was a problem hiding this comment.
The cluster key list command required an argument, thus defaulting to NoArgs but allowing clients to set them if needed.
Davidonium
commented
Apr 10, 2026
| ) | ||
|
|
||
| func newKeyListCommand(s *state.State) *cobra.Command { | ||
| return base.DescribeCmd[*clusterauthv2.ListDatabaseApiKeysResponse]{ |
Collaborator
Author
There was a problem hiding this comment.
This was a hack to get the argument, fixed.
Davidonium
commented
Apr 10, 2026
Comment on lines
-229
to
-242
| func TestListClusters_NextPageTokenPrintedAsFooter(t *testing.T) { | ||
| env := testutil.NewTestEnv(t) | ||
|
|
||
| token := "footer-token" | ||
| env.Server.ListClustersCalls.Returns(&clusterv1.ListClustersResponse{ | ||
| Items: []*clusterv1.Cluster{{Id: "cluster-1"}}, | ||
| NextPageToken: &token, | ||
| }, nil) | ||
|
|
||
| stdout, _, err := testutil.Exec(t, env, "cluster", "list", "--page-size", "1") | ||
| require.NoError(t, err) | ||
|
|
||
| assert.Contains(t, stdout, "Next page token: footer-token") | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Printing the next token was breaking the pattern for the rest of the tables. Also most CLIs don't print it when printing in plain text. The next token is present when passing --json in most CLIs, will do the same in ours.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.