a11y: fix funny-toast color contrast using Bootstrap utility classes#528
Open
xpoes123 wants to merge 1 commit into
Open
a11y: fix funny-toast color contrast using Bootstrap utility classes#528xpoes123 wants to merge 1 commit into
xpoes123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the inline
style="background-color: yellow"andtext-dangeron the#funny-toastheader with Bootstrap utility classes that meet WCAG contrast requirements.Problem
In both
client/play/tossups/index.htmlandclient/play/mp/room.html, the toast header used:style="background-color: yellow"— bypasses Bootstrap themingclass="... text-danger"— red text on yellow background yields ~4.0:1 contrast, which fails WCAG AA for normal-weight text (threshold: 4.5:1)Changes
styleattribute; replaces withbg-warningBootstrap utility class.text-dangertotext-dark, giving thebg-warning+text-darkpairing (~11.7:1 contrast) standard in Bootstrap's own documentation.Risk & testing
Both files are updated identically. Toast IDs,
role="alert",aria-live, andaria-atomicattributes are unchanged. The high-visibility yellow intent is preserved viabg-warning.node --checkpasses.