-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix description of equation in polynomial_autograd.py example #3897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
telamonian
wants to merge
3
commits into
pytorch:main
Choose a base branch
from
telamonian:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3
−5
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2,8 +2,8 @@ | |||||
| PyTorch: Tensors and autograd | ||||||
| ------------------------------- | ||||||
|
|
||||||
| A third order polynomial, trained to predict :math:`y=\sin(x)` from :math:`-\pi` | ||||||
| to :math:`\pi` by minimizing squared Euclidean distance. | ||||||
| A third order polynomial, trained to predict :math:`y=e^x` from :math:`-1` | ||||||
| to :math:`1` by minimizing squared Euclidean distance. | ||||||
|
|
||||||
| This implementation computes the forward pass using operations on PyTorch | ||||||
| Tensors, and uses PyTorch autograd to compute gradients. | ||||||
|
|
@@ -14,7 +14,6 @@ | |||||
| holding the gradient of ``x`` with respect to some scalar value. | ||||||
| """ | ||||||
| import torch | ||||||
| import math | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep import to use |
||||||
|
|
||||||
| # We want to be able to train our model on an `accelerator <https://pytorch.org/docs/stable/torch.html#accelerators>`__ | ||||||
| # such as CUDA, MPS, MTIA, or XPU. If the current accelerator is available, we will use it. Otherwise, we use the CPU. | ||||||
|
|
@@ -39,7 +38,6 @@ | |||||
| c = torch.randn((), dtype=dtype, requires_grad=True) | ||||||
| d = torch.randn((), dtype=dtype, requires_grad=True) | ||||||
|
|
||||||
| initial_loss = 1. | ||||||
| learning_rate = 1e-5 | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| for t in range(5000): | ||||||
| # Forward pass: compute predicted y using operations on Tensors. | ||||||
|
|
@@ -50,7 +48,7 @@ | |||||
| # loss.item() gets the scalar value held in the loss. | ||||||
| loss = (y_pred - y).pow(2).sum() | ||||||
|
|
||||||
| # Calculare initial loss, so we can report loss relative to it | ||||||
| # Calculate initial loss, so we can report loss relative to it | ||||||
| if t==0: | ||||||
| initial_loss=loss.item() | ||||||
|
|
||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep original description.