Add pass to make the model inputs use the channels last dim order.#21392
Open
MartinPavella wants to merge 3 commits into
Open
Conversation
The pass preserves the dim order of the inputs, but internally the graph will use only the contiguous dim order.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21392
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 5c49b2c with merge base ad52be9 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables any model with 4D inputs to consume channels last data. As part of #19299, it is a step towards a model with channels last operators and no runtime permutations.
Fixes #20096.
This PR is based on 2 others for testing purposes. Before merging, this dependency will be removed, so only the last commit is relevant for review.
Test plan
pytest backends/transforms/test/test_make_inputs_channels_last.py