Add timeout default in NeutronBackend (#21293)#21293
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21293
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit f446938 with merge base 30bf6af ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113453148. |
This PR needs a
|
rascani
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
|
||
| // allocateInstance returns raw, uninitialized memory (no constructor runs), so | ||
| // set the driver-config timeout explicitly. | ||
| cfg->mcfg.timeoutSeconds = 60; |
There was a problem hiding this comment.
Note that the timeout is not applicable to RT700, it applies to Neutron-S architectures where the inference can be invoked in the non-blocking mode.
1c85f4b to
e845c04
Compare
Summary: The driver header specifies "60" as a default but is never set. Here, we set the default accordingly. Without a default, there is a crash in our specific setup. This may because ET allocates the object, but does not memset or anything so there may be garbage values that negatively impact. Reviewed By: rascani Differential Revision: D113453148
Summary: The driver header specifies "60" as a default but is never set. Here, we set the default accordingly. Without a default, there is a crash in our specific setup. This may because ET allocates the object, but does not memset or anything so there may be garbage values that negatively impact. Reviewed By: rascani Differential Revision: D113453148
e845c04 to
f446938
Compare
Summary:
The driver header specifies "60" as a default but is never set.
Here, we set the default accordingly.
Without a default, there is a crash in our specific setup.
This may because ET allocates the object, but does not memset or anything so there may be garbage values that negatively impact.
Reviewed By: rascani
Differential Revision: D113453148