Skip to content

Add timeout default in NeutronBackend (#21293)#21293

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
JakeStevens:export-D113453148
Jul 27, 2026
Merged

Add timeout default in NeutronBackend (#21293)#21293
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
JakeStevens:export-D113453148

Conversation

@JakeStevens

@JakeStevens JakeStevens commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary:

The driver header specifies "60" as a default but is never set.

Here, we set the default accordingly.

Without a default, there is a crash in our specific setup.

This may because ET allocates the object, but does not memset or anything so there may be garbage values that negatively impact.

Reviewed By: rascani

Differential Revision: D113453148

@pytorch-bot

pytorch-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21293

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit f446938 with merge base 30bf6af (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2026
@meta-codesync

meta-codesync Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113453148.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@rascani rascani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@robert-kalmar
robert-kalmar requested a review from jirioc July 24, 2026 06:14

// allocateInstance returns raw, uninitialized memory (no constructor runs), so
// set the driver-config timeout explicitly.
cfg->mcfg.timeoutSeconds = 60;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the timeout is not applicable to RT700, it applies to Neutron-S architectures where the inference can be invoked in the non-blocking mode.

@meta-codesync meta-codesync Bot changed the title Add timeout default in NeutronBackend Add timeout default in NeutronBackend (#21293) Jul 24, 2026
JakeStevens added a commit to JakeStevens/executorch that referenced this pull request Jul 24, 2026
Summary:

The driver header specifies "60" as a default but is never set.

Here, we set the default accordingly.

Without a default, there is a crash in our specific setup.

This may because ET allocates the object, but does not memset or anything so there may be garbage values that negatively impact.

Reviewed By: rascani

Differential Revision: D113453148
Summary:

The driver header specifies "60" as a default but is never set.

Here, we set the default accordingly.

Without a default, there is a crash in our specific setup.

This may because ET allocates the object, but does not memset or anything so there may be garbage values that negatively impact.

Reviewed By: rascani

Differential Revision: D113453148
@meta-codesync
meta-codesync Bot merged commit c967b70 into pytorch:main Jul 27, 2026
184 of 185 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants