Skip to content

Fix Windows CUDA build: guard extension_cuda compile options to CXX #20184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shoumikhin merged 2 commits into from
Jun 10, 2026
+6 −1
Merged

Fix Windows CUDA build: guard extension_cuda compile options to CXX #20184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26eeac5
Guard extension_cuda compile options to CXX to fix Windows CUDA build
shoumikhin Jun 10, 2026
0d1780c
Run cuda-windows CI on extension/cuda changes
shoumikhin Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/cuda-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ on:
- .github/workflows/cuda-windows.yml
- backends/cuda/**
- backends/aoti/**
- extension/cuda/**
workflow_dispatch:

concurrency:
Expand Down Expand Up @@ -49,6 +50,7 @@ jobs:
(
contains(needs.changed-files.outputs.changed-files, 'backends/cuda') ||
contains(needs.changed-files.outputs.changed-files, 'backends/aoti') ||
contains(needs.changed-files.outputs.changed-files, 'extension/cuda') ||
contains(needs.changed-files.outputs.changed-files, '.github/workflows/cuda-windows.yml') ||
needs.run-decision.outputs.is-full-run == 'true'
)
Expand Down Expand Up @@ -150,6 +152,7 @@ jobs:
(
contains(needs.changed-files.outputs.changed-files, 'backends/cuda') ||
contains(needs.changed-files.outputs.changed-files, 'backends/aoti') ||
contains(needs.changed-files.outputs.changed-files, 'extension/cuda') ||
contains(needs.changed-files.outputs.changed-files, '.github/workflows/cuda-windows.yml') ||
needs.run-decision.outputs.is-full-run == 'true'
)
Expand Down
4 changes: 3 additions & 1 deletion extension/cuda/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ find_package(CUDAToolkit REQUIRED)
add_library(extension_cuda SHARED caller_stream.cpp)
target_link_libraries(extension_cuda PUBLIC CUDA::cudart)
target_include_directories(extension_cuda PUBLIC ${_common_include_directories})
target_compile_options(extension_cuda PUBLIC ${_common_compile_options})
target_compile_options(
extension_cuda PUBLIC "$<$<COMPILE_LANGUAGE:CXX>:${_common_compile_options}>"
)
target_compile_definitions(
extension_cuda PRIVATE EXECUTORCH_EXTENSION_CUDA_BUILDING
)
Expand Down
Loading