Add KV cache to the EAGLE-3 draft head#20152
Draft
digantdesai wants to merge 1 commit into
Draft
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20152
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 PendingAs of commit d782162 with merge base dc55469 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 9, 2026
metascroy
reviewed
Jun 9, 2026
| return torch.cat((-x2, x1), dim=-1) | ||
|
|
||
|
|
||
| class Eagle3KVCache(nn.Module): |
Contributor
There was a problem hiding this comment.
What distinguishes this from our standard KVCache? Can we just import the standard one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a flat KV cache and an explicit-mask attention path (forward_cached) to the
draft head so a proposal step reuses cached keys/values instead of recomputing
the prefix's projections and MLP. Attention still scores against the full
max_seq_len buffer under a static causal mask, matching the target's cache and
keeping the path export-friendly. The stateless is_causal forward is unchanged.
forward_cached requires batch size 1 and contiguous-from-0 writes (overwrites
for speculative rollback are allowed, gapped seeds are not); the invariant is
enforced by an eager-only validator that is skipped under export. Tests cover
cached prefill plus single-step decode against the stateless recompute, rollback
reseeding, and rejection of gapped/offset seeds and B>1.
Authored with assistance from Claude Code.