Expand fbcode buck test coverage for arm backend (58→162 test targets)#18817
Expand fbcode buck test coverage for arm backend (58→162 test targets)#18817digantdesai wants to merge 1 commit intopytorch:mainfrom
Conversation
Summary: Expand the arm backend test coverage in fbcode by adding all available test files from ops/, quantizer/, and misc/ directories to targets.bzl. Reviewed By: 3l1 Differential Revision: D96521268
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18817
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 68a6157 with merge base 36e8ed9 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@digantdesai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96521268. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Expands the Arm backend’s Buck-based pytest coverage in fbcode by enumerating many more existing test files, and aligns Conv3D lowering with the common tosa_serializer import style used throughout the Arm backend.
Changes:
- Greatly expands
backends/arm/test/targets.bzlto include many moreops/,quantizer/, andmisc/pytest targets (with some explicitly disabled and annotated). - Updates Conv3D TOSA lowering to import
tosa_serializerdirectly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| backends/arm/test/targets.bzl | Adds many more pytest targets for Arm backend tests and documents known exclusions. |
| backends/arm/operators/op_tosa_conv3d.py | Switches Conv3D visitor to import tosa_serializer directly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Operators | ||
| test_files += [ | ||
| "ops/test_abs.py", | ||
| "ops/test_add.py", | ||
| "ops/test_addmm.py", | ||
| "ops/test_amax.py", |
There was a problem hiding this comment.
The PR description/title claims this adds “all available” tests from ops/, quantizer/, and misc/, but this target list still omits many existing tests in those directories (e.g., ops/test_acos.py, ops/test_any.py, misc/test_high_rank_permute_view_invariants.py, etc.). Either update the description to reflect that this is a curated subset, or switch to native.glob(["ops/test_.py"], ...) / native.glob(["misc/test_.py"], ...) with an explicit exclusion list so coverage doesn’t silently drift as new tests are added.
| "quantizer/test_conv_relu_fusing.py", | ||
| "quantizer/test_generic_annotater.py", | ||
| "quantizer/test_partial_quantization.py", | ||
| # "quantizer/test_preserve_kwargs.py", # needs executorch.backends.test.harness.stages (no BUCK target) |
There was a problem hiding this comment.
This exclusion reason appears incorrect: executorch.backends.test.harness.stages is included in the public Buck target //executorch/backends/test/harness:tester (which is already a dependency of //executorch/backends/arm/test:arm_tester_lib). If quantizer/test_preserve_kwargs.py is being skipped for another reason (e.g., failures), please update the comment; otherwise it looks like it should be enabled to increase coverage.
| # "quantizer/test_preserve_kwargs.py", # needs executorch.backends.test.harness.stages (no BUCK target) | |
| "quantizer/test_preserve_kwargs.py", |
| "misc/test_extract_io_params_tosa.py", | ||
| # "misc/test_int64.py", # 5 failures: int64 overflow/chain handling issues | ||
| # "misc/test_lifted_tensor.py", # needs executorch.backends.test.harness.stages (no BUCK target) | ||
| "misc/test_mixed_fp_bf16_partition.py", |
There was a problem hiding this comment.
Same as above for this exclusion: executorch.backends.test.harness.stages has a Buck target (//executorch/backends/test/harness:tester) and is already pulled in transitively via //executorch/backends/arm/test:arm_tester. If this test is disabled due to failures/flake, please update the comment accordingly; otherwise consider enabling it to match the stated goal of expanding coverage.
Summary:
Expand the arm backend test coverage in fbcode by adding all available
test files from ops/, quantizer/, and misc/ directories to targets.bzl.
Reviewed By: 3l1
Differential Revision: D96521268