Skip to content

Expand fbcode buck test coverage for arm backend (58→162 test targets)#18817

Open
digantdesai wants to merge 1 commit intopytorch:mainfrom
digantdesai:export-D96521268
Open

Expand fbcode buck test coverage for arm backend (58→162 test targets)#18817
digantdesai wants to merge 1 commit intopytorch:mainfrom
digantdesai:export-D96521268

Conversation

@digantdesai
Copy link
Copy Markdown
Contributor

Summary:
Expand the arm backend test coverage in fbcode by adding all available
test files from ops/, quantizer/, and misc/ directories to targets.bzl.

Reviewed By: 3l1

Differential Revision: D96521268

Summary:
Expand the arm backend test coverage in fbcode by adding all available
test files from ops/, quantizer/, and misc/ directories to targets.bzl.

Reviewed By: 3l1

Differential Revision: D96521268
Copilot AI review requested due to automatic review settings April 10, 2026 16:09
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 10, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18817

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 2 Unrelated Failures

As of commit 68a6157 with merge base 36e8ed9 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Apr 10, 2026

@digantdesai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D96521268.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Expands the Arm backend’s Buck-based pytest coverage in fbcode by enumerating many more existing test files, and aligns Conv3D lowering with the common tosa_serializer import style used throughout the Arm backend.

Changes:

  • Greatly expands backends/arm/test/targets.bzl to include many more ops/, quantizer/, and misc/ pytest targets (with some explicitly disabled and annotated).
  • Updates Conv3D TOSA lowering to import tosa_serializer directly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
backends/arm/test/targets.bzl Adds many more pytest targets for Arm backend tests and documents known exclusions.
backends/arm/operators/op_tosa_conv3d.py Switches Conv3D visitor to import tosa_serializer directly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 17 to +22
# Operators
test_files += [
"ops/test_abs.py",
"ops/test_add.py",
"ops/test_addmm.py",
"ops/test_amax.py",
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description/title claims this adds “all available” tests from ops/, quantizer/, and misc/, but this target list still omits many existing tests in those directories (e.g., ops/test_acos.py, ops/test_any.py, misc/test_high_rank_permute_view_invariants.py, etc.). Either update the description to reflect that this is a curated subset, or switch to native.glob(["ops/test_.py"], ...) / native.glob(["misc/test_.py"], ...) with an explicit exclusion list so coverage doesn’t silently drift as new tests are added.

Copilot uses AI. Check for mistakes.
"quantizer/test_conv_relu_fusing.py",
"quantizer/test_generic_annotater.py",
"quantizer/test_partial_quantization.py",
# "quantizer/test_preserve_kwargs.py", # needs executorch.backends.test.harness.stages (no BUCK target)
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exclusion reason appears incorrect: executorch.backends.test.harness.stages is included in the public Buck target //executorch/backends/test/harness:tester (which is already a dependency of //executorch/backends/arm/test:arm_tester_lib). If quantizer/test_preserve_kwargs.py is being skipped for another reason (e.g., failures), please update the comment; otherwise it looks like it should be enabled to increase coverage.

Suggested change
# "quantizer/test_preserve_kwargs.py", # needs executorch.backends.test.harness.stages (no BUCK target)
"quantizer/test_preserve_kwargs.py",

Copilot uses AI. Check for mistakes.
Comment on lines +166 to +169
"misc/test_extract_io_params_tosa.py",
# "misc/test_int64.py", # 5 failures: int64 overflow/chain handling issues
# "misc/test_lifted_tensor.py", # needs executorch.backends.test.harness.stages (no BUCK target)
"misc/test_mixed_fp_bf16_partition.py",
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above for this exclusion: executorch.backends.test.harness.stages has a Buck target (//executorch/backends/test/harness:tester) and is already pulled in transitively via //executorch/backends/arm/test:arm_tester. If this test is disabled due to failures/flake, please update the comment accordingly; otherwise consider enabling it to match the stated goal of expanding coverage.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants