fix yolov3 on Windows - #2697
Open
bjarzemb wants to merge 1 commit into
Open
Conversation
Author
|
@atalman Can you help me to merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
yolov3train mode on Windows (path mangled byshlex.split)Problem
In
torchbenchmark/models/yolov3/__init__.pythe train args are built by interpolating the absoluteDATA_DIRinto a string parsed withshlex.split. In POSIX mode (default),\is an escape char, so on Windows the path backslashes are stripped and--datapoints to a non-existent file, makingcheck_filefail withAssertionError.Fix
Use forward slashes (valid on Windows) before
shlex.split:Before
After