feat: support configurable constant-fold exclusions - #4450
Open
fs-eire wants to merge 1 commit into
Open
Conversation
fs-eire
force-pushed
the
constant-fold-exclusion-mechanics
branch
from
July 30, 2026 22:27
d688a7c to
7c18031
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new lowering pass
mark_constant_fold_exclusionsjust before theconstant_foldpass. The new pass is used to mark specific nodes so that they will not be constant folded in the next pass.The feature uses a rule based, configurable approach. There are pre-defined rules, and by default all rules are applied. User can use a
disabled_constant_fold_exclusionssetting to disable one or more rules by specifying the rule name.Currently, this PR should not affect the behavior because the rule list is empty. I will work on add a new rule related to attention in the next PR, which depends on the current PR.
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: