Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
I don't think the match overloads are correct here: This would allow calls such as ...match(123) (where 123 is a PID), which wouldn't work at runtime. Also technically calls such as ...match("/path", -1, None) should work and I suggest to allow this in stubs as well. Please see my suggestions below. The alternative is to use * to mark arguments as kw-only.
Also, callbacks where the return value is ignored should use object as return type, not Any. Otherwise, as Any types must be explained, the return type must be explained in a comment.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
I fixed the |
No description provided.