Skip to content

Remove redundant check_pyspecific task #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hugovk wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −21
Open

Remove redundant check_pyspecific task #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions run_release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,25 +538,6 @@ def run_autoconf(db: ReleaseShelf) -> None:
)


def check_pyspecific(db: ReleaseShelf) -> None:
with open(
db["git_repo"] / "Doc" / "tools" / "extensions" / "pyspecific.py"
) as pyspecific:
for line in pyspecific:
if "SOURCE_URI =" in line:
break
expected_branch = db["release"].branch
expected = (
f"SOURCE_URI = 'https://github.com/python/cpython/tree/{expected_branch}/%s'"
)
if expected != line.strip():
raise ReleaseException(
f"SOURCE_URI is incorrect (it needs changing before beta 1):\n"
f"expected: {expected}\n"
f"got : {line.strip()}"
)


def bump_version(db: ReleaseShelf) -> None:
with cd(db["git_repo"]):
release_mod.bump(db["release"])
Expand Down Expand Up @@ -1453,8 +1434,6 @@ def _api_key(api_key: str) -> str:
Task(check_cpython_repo_is_clean, "Checking CPython repository is clean"),
Task(run_autoconf, "Running autoconf"),
Task(check_cpython_repo_is_clean, "Checking CPython repository is clean"),
Task(check_pyspecific, "Checking pyspecific"),
Task(check_cpython_repo_is_clean, "Checking CPython repository is clean"),
Task(create_tag, "Create tag"),
Task(push_to_local_fork, "Push new tags and branches to private fork"),
Task(start_build_release, "Start the build-release workflow"),
Expand Down
Loading