Skip to content

Enable detached catalog signing for PyManager index files#366

Open
zooba wants to merge 16 commits intomainfrom
indexsign
Open

Enable detached catalog signing for PyManager index files#366
zooba wants to merge 16 commits intomainfrom
indexsign

Conversation

@zooba
Copy link
Copy Markdown
Member

@zooba zooba commented Apr 13, 2026

Also synchronises sign-files.yml with the PyManager repository and streamlines the release/publishing stages to reduce the chances of publishing improperly signed files.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Windows release/publishing pipeline to support detached catalog signing for PyManager index JSON files, and refactors signing/publish steps to better align with the PyManager repository and reduce the risk of publishing unsigned artifacts.

Changes:

  • Add support for generating and uploading a .cat catalog signature alongside the PyManager index JSON.
  • Refactor signing tooling setup via sign-files.yml, including legacy signtool support and improved env handling.
  • Adjust publish pipeline wiring to pass signing configuration through to the PyManager publish stage.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.

File Description
windows-release/stage-publish-pymanager.yml Adds signing configuration/setup and adjusts publish vs. no-upload behavior.
windows-release/sign-files.yml Extends signing template with legacy tool support and updated file selection logic.
windows-release/merge-and-upload.py Generates/signs an index catalog (.cat) and uploads it with the index.
windows-release/azure-pipelines.yml Threads SigningCertificate through to the PyManager publish stage with Unsigned mapped to empty.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants