gh-154053: Fix compilation of the ssl module against LibreSSL#154054
Merged
serhiy-storchaka merged 1 commit intoJul 19, 2026
Conversation
LibreSSL does not provide SSL_CTX_set1_sigalgs_list() or SSL_CTX_set1_client_sigalgs_list(), added in pythongh-138252, so _ssl failed to compile against LibreSSL on 3.15+. Guard the set_server_sigalgs() and set_client_sigalgs() methods so they raise NotImplementedError on LibreSSL, and skip the corresponding tests.
serhiy-storchaka
added
the
needs backport to 3.15
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-154075 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 19, 2026
…H-154054) (GH-154075) LibreSSL does not provide SSL_CTX_set1_sigalgs_list() or SSL_CTX_set1_client_sigalgs_list(), added in gh-138252, so _ssl failed to compile against LibreSSL on 3.15+. Guard the set_server_sigalgs() and set_client_sigalgs() methods so they raise NotImplementedError on LibreSSL, and skip the corresponding tests. (cherry picked from commit 39b058f) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since gh-138252 (TLS signature-algorithm support, 3.15+),
_sslfails to compile against LibreSSL, which does not provideSSL_CTX_set1_sigalgs_list()/SSL_CTX_set1_client_sigalgs_list():With
-Werror=implicit-function-declarationthis is fatal, so_sslis not built at all on LibreSSL (regression from 3.14).This PR guards the
set_client_sigalgs/set_server_sigalgsmethods so they raiseNotImplementedErroron LibreSSL (matching how other library-unavailable features are handled in_ssl.c), and skips the correspondingtest_ssltests.Verified:
_sslnow compiles; the 7 sigalgs tests skip; the remainingtest_sslfailures are identical to those already present on 3.14 (pre-existing LibreSSL divergences), i.e. no new failures.