gh-151631: Fix traceback when parent package is blocked in sys.modules#151835
Open
bhuvi27 wants to merge 1 commit into
Open
gh-151631: Fix traceback when parent package is blocked in sys.modules#151835bhuvi27 wants to merge 1 commit into
bhuvi27 wants to merge 1 commit into
Conversation
…modules _find_incompatible_extension_module() must not import a parent package blocked via sys.modules[parent] = None when formatting ModuleNotFoundError.
hroncok
reviewed
Jun 22, 2026
hroncok
left a comment
hroncok
left a comment
Contributor
There was a problem hiding this comment.
I have one nitpick, but it looks good otherwise. Thank you!
| import logging | ||
| with self.assertLogs('test_traceback', level='ERROR') as cm_logs: | ||
| logging.getLogger('test_traceback').exception('fail', exc_info=exc) | ||
| self.assertIn("No module named 'pkg.mod'", cm_logs.output[0]) |
Contributor
There was a problem hiding this comment.
Maybe the 3 main use cases should be 3 separate tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151631.
_find_incompatible_extension_module()callsimportlib.resources.files(parent), which tries to import the parent package. That blows up whensys.modules[parent]isNone— the documented way to block imports in tests.Catch
ImportErrorand bail out instead of raising a secondModuleNotFoundErrorwhile formatting the original one.