gh-151303 : Improve `SyntaxError` suggestions for common operator typos and cross-language mistakes by Aniketsy · Pull Request #151375 · python/cpython

Aniketsy · 2026-06-11T17:46:06Z

Issue: Improve SyntaxError suggestions for common operator typos and cross-language mistakes #151303

…e-151303.mzlJxi.rst

StanFromIreland · 2026-06-13T09:40:18Z

+    | invalid_eqeqeq

+invalid_diamond_op:
+    | a='<' b='>' { RAISE_SYNTAX_ERROR_KNOWN_RANGE(a, b, "invalid syntax.  Maybe you meant '!=' instead of '<>'?") }


Won't this break when __future__.CO_FUTURE_BARRY_AS_BDFL is true?

hmm , yes

aniket@DESKTOP-074O80J:/mnt/d/cpython/cpython$ ./python.exe -c " __futu> from __future__ import barry_as_FLUFL > 1 < > 2 > " File "<string>", line 3 1 < > 2 ^^^ SyntaxError: invalid syntax. Maybe you meant '!=' instead of '<>'?

please let me know your thoughts on this ...

aniket@DESKTOP-074O80J:/mnt/d/cpython/cpython$ git diff Grammar/python.gram diff --git a/Grammar/python.gram b/Grammar/python.gram index 61a6d5ea90..19ef406437 100644 --- a/Grammar/python.gram +++ b/Grammar/python.gram @@ -805,7 +805,11 @@ compare_op_bitwise_or_pair[CmpopExprPair*]: | invalid_eqeqeq invalid_diamond_op: - | a='<' b='>' { RAISE_SYNTAX_ERROR_KNOWN_RANGE(a, b, "invalid syntax. Maybe you meant '!=' instead of '<>'?") } + | a='<' b='>' { + (p->flags & PyPARSE_BARRY_AS_BDFL) + ? RAISE_SYNTAX_ERROR_KNOWN_RANGE(a, b, "invalid syntax. Maybe you meant '<>' instead of '< >'?") + : RAISE_SYNTAX_ERROR_KNOWN_RANGE(a, b, "invalid syntax. Maybe you meant '!=' instead of '<>'?") + } eq_bitwise_or[CmpopExprPair*]: '==' a=bitwise_or { _PyPegen_cmpop_expr_pair(p, Eq, a) } invalid_eqeqeq: | a='==' b='=' { RAISE_SYNTAX_ERROR_KNOWN_RANGE(a, b, "invalid syntax. Maybe you meant '==' instead of '==='?") }

output:

aniket@DESKTOP-074O80J:/mnt/d/cpython/cpython$ ./python.exe -c "1 < > 2" File "<string>", line 1 1 < > 2 ^^^ SyntaxError: invalid syntax. Maybe you meant '!=' instead of '<>'?

aniket@DESKTOP-074O80J:/mnt/d/cpython/cpython$ ./python.exe -c " __futu> from __future__ import barry_as_FLUFL > 1 < > 2 > " File "<string>", line 3 1 < > 2 ^^^ SyntaxError: invalid syntax. Maybe you meant '<>' instead of '< >'?

hmm, yes

No, this example doesn't break __future__ import. But I suspect, that __future__.CO_FUTURE_BARRY_AS_BDFL is the reason that your code doesn't work without spaces. This can be "fixed" by this patch:

diff --git a/Tools/build/generate_token.py b/Tools/build/generate_token.py index 9ee5ec86e75..28a0ce1ff78 100755 --- a/Tools/build/generate_token.py +++ b/Tools/build/generate_token.py @@ -178,7 +178,7 @@ def generate_chars_to_token(mapping, n=1): def make_c(infile, outfile='Parser/token.c'): tok_names, ERRORTOKEN, string_to_tok = load_tokens(infile) - string_to_tok['<>'] = string_to_tok['!='] +# string_to_tok['<>'] = string_to_tok['!='] chars_to_token = {} for string, value in string_to_tok.items(): assert 1 <= len(string) <= 3

Look at the difference:

$ cat a.py 1 =! 2 $ cat a.py | ./python -m tokenize 1,0-1,1: NUMBER '1' 1,2-1,3: OP '=' 1,3-1,4: OP '!' 1,5-1,6: NUMBER '2' 1,6-1,7: NEWLINE '\n' 2,0-2,0: ENDMARKER ''

vs

$ cat a.py 1 <> 2 $ cat a.py | ./python -m tokenize 1,0-1,1: NUMBER '1' 1,2-1,4: OP '<>' 1,5-1,6: NUMBER '2' 1,6-1,7: NEWLINE '\n' 2,0-2,0: ENDMARKER ''

Regardless on a joke, it looks as a tokenizer bug. I'll open a separate issue.

thanks for looking into this, i'll revert the changes

No, this example doesn't break future import.

It still does break it, we're suggesting != for < > which is invalid syntax when __future__.CO_FUTURE_BARRY_AS_BDFL is true.

Yes, this is wrong, see my comment below. But nothing to do with __future__.barry_as_FLUFL.

Currently, we have a hidden token (<> is alias for !=) in the grammar. So, this patch will not produce an error without a space between. See #151464.

skirpichev · 2026-06-14T02:20:32Z

Sorry, this doesn't look right for me, just as in another your PR: #150906 (comment)

serhiy-storchaka

Like in the previous PR, check that there is no gap between tokens.

serhiy-storchaka · 2026-06-14T07:46:34Z


+    def test_diamond_operator(self):
+        self._check_error(
+            "1 < > 2",


There should not be space in the middle.

Aniketsy · 2026-06-15T03:47:02Z

@skirpichev thanks for the review, i've updated with helper function

skirpichev · 2026-06-17T07:45:24Z

+        compile(
+            "from __future__ import barry_as_FLUFL\n1<>2",
+            "<test>", "exec",
+        )


Check error for 'a < > b' in this case.

File "<test>", line 3 a < > b ^ SyntaxError: invalid syntax

I meant, please add a test.

ahh 😿 my bad, i'll add 👍

skirpichev · 2026-06-17T08:08:30Z

+        if (strcmp(tok_str, "<>") == 0) {
+            RAISE_SYNTAX_ERROR("invalid syntax.  Are you trying to overthrow the SC?  Use operator \"!=\"!");
+            return -1;
+        }


I would prefer not use this workaround for #151464. Leave "<>" case for another PR.

Should i revert the changes for this case ?

This is my suggestion, yes.

serhiy-storchaka · 2026-06-17T09:00:51Z

We wait for other PR to be merged first.

Improve SyntaxError suggestions for common operator typos

9472172

Aniketsy requested review from lysnikolaou and pablogsal as code owners June 11, 2026 17:46

bedevere-app Bot added the awaiting review label Jun 11, 2026

bedevere-app Bot mentioned this pull request Jun 11, 2026

Improve SyntaxError suggestions for common operator typos and cross-language mistakes #151303

Open

This comment was marked as resolved.

Sign in to view

StanFromIreland reviewed Jun 11, 2026

View reviewed changes

Comment thread Grammar/python.gram Outdated

Aniketsy and others added 4 commits June 12, 2026 03:31

add question mark in the suggestion and tests

65cf172

update tests

34a7ef1

📜🤖 Added by blurb_it.

431174b

improve syntaxerror message <> typo

bb79f1f

Aniketsy commented Jun 13, 2026

View reviewed changes

Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-06-12-03-41-39.gh-issue-151303.mzlJxi.rst Outdated

Update Misc/NEWS.d/next/Core_and_Builtins/2026-06-12-03-41-39.gh-issu…

30e8188

…e-151303.mzlJxi.rst

StanFromIreland reviewed Jun 13, 2026

View reviewed changes

improve syntaxerror message <> typo

f039f43

skirpichev reviewed Jun 14, 2026

View reviewed changes

Comment thread Grammar/python.gram Outdated

Aniketsy mentioned this pull request Jun 14, 2026

gh-146495: Improve SyntaxError message for && and || operators #150906

Open

serhiy-storchaka reviewed Jun 14, 2026

View reviewed changes

Aniketsy added 2 commits June 14, 2026 10:49

Improve SyntaxError suggestions for common operator typos

b2c9971

fix and update tests

d176b08

skirpichev requested changes Jun 15, 2026

View reviewed changes

bedevere-app Bot added awaiting core review and removed awaiting review labels Jun 15, 2026

add helper function, update tests

d89dfcf

skirpichev reviewed Jun 17, 2026

View reviewed changes

skirpichev requested review from StanFromIreland and serhiy-storchaka June 17, 2026 08:11

Uh oh!

Conversation

Aniketsy commented Jun 11, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StanFromIreland Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

skirpichev commented Jun 14, 2026

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Aniketsy commented Jun 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka commented Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Aniketsy commented Jun 11, 2026 •

edited by bedevere-app Bot

Loading

StanFromIreland Jun 14, 2026 •

edited

Loading