Skip to content

gh-150907: Fix dynamic_annotations.h when built with C++ and Valgrind#150914

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:dynamic_annotations
Jun 5, 2026
Merged

gh-150907: Fix dynamic_annotations.h when built with C++ and Valgrind#150914
vstinner merged 1 commit into
python:mainfrom
vstinner:dynamic_annotations

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Jun 4, 2026

Add extern "C++" scope for the C++ template.

…lgrind

Add extern "C++" scope for the C++ template.
@vstinner vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 4, 2026
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 5, 2026
@bedevere-bot
Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 90f186d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F150914%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 5, 2026
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Jun 5, 2026

buildbot/AMD64 FreeBSD Refleaks PR
buildbot/AMD64 Windows PGO Tailcall PR
buildbot/ARM64 MacOS M1 Refleaks NoGIL PR

Unrelated failures: test_logging on these workers, see issue gh-150960.

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Jun 5, 2026

test_cppext currently fails on "AMD64 CentOS9 3.x" and "AMD64 Fedora Stable 3.x" workers.

The test suite passed on these builders with this change:

  • buildbot/aarch64 Fedora Stable PR
  • buildbot/aarch64 CentOS9 PR

@vstinner vstinner merged commit c325012 into python:main Jun 5, 2026
146 of 151 checks passed
@vstinner vstinner deleted the dynamic_annotations branch June 5, 2026 12:11
@miss-islington-app
Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 5, 2026

GH-150962 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 5, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 5, 2026

GH-150963 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 5, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 5, 2026

GH-150964 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 5, 2026
vstinner added a commit that referenced this pull request Jun 5, 2026
…algrind (GH-150914) (#150964)

gh-150907: Fix dynamic_annotations.h when built with C++ and Valgrind (GH-150914)

Add extern "C++" scope for the C++ template.

Fix test_cppext when Python is built with --with-valgrind.
(cherry picked from commit c325012)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Jun 5, 2026
…algrind (GH-150914) (#150963)

gh-150907: Fix dynamic_annotations.h when built with C++ and Valgrind (GH-150914)

Add extern "C++" scope for the C++ template.

Fix test_cppext when Python is built with --with-valgrind.
(cherry picked from commit c325012)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Jun 5, 2026
…algrind (GH-150914) (#150962)

gh-150907: Fix dynamic_annotations.h when built with C++ and Valgrind (GH-150914)

Add extern "C++" scope for the C++ template.

Fix test_cppext when Python is built with --with-valgrind.
(cherry picked from commit c325012)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants