Skip to content

bpo-29750: support non-ASCII passwords in smtplib#15064

Closed
Windsooon wants to merge 3 commits intopython:mainfrom
Windsooon:bpo-29750
Closed

bpo-29750: support non-ASCII passwords in smtplib#15064
Windsooon wants to merge 3 commits intopython:mainfrom
Windsooon:bpo-29750

Conversation

@Windsooon
Copy link
Copy Markdown
Contributor

@Windsooon Windsooon commented Aug 1, 2019 •
edited by bedevere-bot
Loading

issue: https://bugs.python.org/issue29750

I updated the PR based on the review from #8938

https://bugs.python.org/issue29750

@Windsooon Windsooon requested a review from a team as a code owner August 1, 2019 04:11
@Windsooon
Copy link
Copy Markdown
Contributor Author

Windsooon commented Aug 1, 2019

Please review this PR when you have time @taleinat :D

@ZackerySpytz
Copy link
Copy Markdown
Contributor

ZackerySpytz commented Aug 1, 2019

You don't need to create a new PR in order to address review comments. Just update the original PR.

@Windsooon
Copy link
Copy Markdown
Contributor Author

Windsooon commented Sep 11, 2019

Hello, @ZackerySpytz , I use a wrong branch name at the very beginning then deleted it locally by mistake. That is why I use a new PR here.

@seblu
Copy link
Copy Markdown

seblu commented Dec 26, 2019

Python 3.8.0 is still impacted by this.

Patched version 3.8.0 accept passwords with utf8 chars.

@csabella csabella requested review from maxking and taleinat May 28, 2020 23:19
@Leon-001
Copy link
Copy Markdown

Leon-001 commented Jan 4, 2021

Hi,
I just wanted to give some motivation: I had a special character in my password and it took some time until I have figured out, what was going on. It would be great, if this patch could be reviewed!
Thank you all!

@max-toepfer
Copy link
Copy Markdown

max-toepfer commented Apr 21, 2022

Hello, lovely Python dev folks,
as another affected individual I wanted to ask, if this topic is still alive?
Thank you so much for the contributions!

@david david mannequin mentioned this pull request Apr 30, 2022
Open
@MaxwellDupre
Copy link
Copy Markdown
Contributor

MaxwellDupre commented May 10, 2022

Let smtplib support non-ASCII passwords, better
smtplib support for UTF-8 passwords

@arhadthedev
Copy link
Copy Markdown
Member

arhadthedev commented Apr 18, 2023

Closing in favor of SASLprep-based gh-103611.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taleinat taleinat Awaiting requested review from taleinat

@maxking maxking Awaiting requested review from maxking

1 more reviewer

@Jourdelune Jourdelune Jourdelune approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.