Skip to content

bpo-29750: support non-ASCII passwords in smtplib#15064

Closed
Windsooon wants to merge 3 commits intopython:mainfrom
Windsooon:bpo-29750
Closed

bpo-29750: support non-ASCII passwords in smtplib#15064
Windsooon wants to merge 3 commits intopython:mainfrom
Windsooon:bpo-29750

Conversation

@Windsooon
Copy link
Copy Markdown
Contributor

@Windsooon Windsooon commented Aug 1, 2019

issue: https://bugs.python.org/issue29750

I updated the PR based on the review from #8938

https://bugs.python.org/issue29750

@Windsooon
Copy link
Copy Markdown
Contributor Author

Please review this PR when you have time @taleinat :D

@ZackerySpytz
Copy link
Copy Markdown
Contributor

You don't need to create a new PR in order to address review comments. Just update the original PR.

@Windsooon
Copy link
Copy Markdown
Contributor Author

Hello, @ZackerySpytz , I use a wrong branch name at the very beginning then deleted it locally by mistake. That is why I use a new PR here.

@seblu
Copy link
Copy Markdown

seblu commented Dec 26, 2019

Python 3.8.0 is still impacted by this.

Patched version 3.8.0 accept passwords with utf8 chars.

@csabella csabella requested review from maxking and taleinat May 28, 2020 23:19
@Leon-001
Copy link
Copy Markdown

Leon-001 commented Jan 4, 2021

Hi,
I just wanted to give some motivation: I had a special character in my password and it took some time until I have figured out, what was going on. It would be great, if this patch could be reviewed!
Thank you all!

@max-toepfer
Copy link
Copy Markdown

Hello, lovely Python dev folks,
as another affected individual I wanted to ask, if this topic is still alive?
Thank you so much for the contributions!

@MaxwellDupre
Copy link
Copy Markdown
Contributor

Let smtplib support non-ASCII passwords, better
smtplib support for UTF-8 passwords

@arhadthedev
Copy link
Copy Markdown
Member

Closing in favor of SASLprep-based gh-103611.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.