Speed up counting in statistics.fmean()#148875
Merged
rhettinger merged 2 commits intopython:mainfrom Apr 23, 2026
Merged
Conversation
Shrey-N
reviewed
Apr 22, 2026
Co-authored-by: Shrey Naithani <shrey.naithani@shelllite.tech>
eendebakpt
reviewed
Apr 23, 2026
| counter = count() | ||
| total = fsum(map(itemgetter(0), zip(data, counter))) | ||
| n = next(counter) | ||
| counter = count(1) |
Contributor
There was a problem hiding this comment.
Nice trick!
I like the current PR, but just for fun: the counter still produces an int on every iteration. Much faster is:
counter = repeat(True, 2**60)
total = fsum(compress(data, counter))
n = 2**60 - counter.__reduce_ex__(4)[1][1]
(older python version, the __reduce_ex__ support has been removed and I cannot find any other object with an internal counter)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a faster counting strategy that avoids tuple creation, indexing, and destruction.
Baseline timing:
After the PR: