gh-148596: Fix callback return handling for subclassed ctypes types#148742
Open
dplusj wants to merge 2 commits intopython:mainfrom
Open
gh-148596: Fix callback return handling for subclassed ctypes types#148742dplusj wants to merge 2 commits intopython:mainfrom
dplusj wants to merge 2 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary: Fix handling of callback return values in
ctypesFixes the handling of callback return values in
ctypeswhen a callback returns an instance of a subclass of a simple ctypes type (e.g., a subclass ofc_int).Closes: gh-148596
Problem
When a Python callback created with
CFUNCTYPEreturns an instance of a subclassed simplectypestype, the return value is passed directly to the correspondingsetfuncin_ctypes.Example Scenario:
The Issue:
setfuncexpects a native Python value (such asintorfloat).ctypesinstances.TypeError, reported as an unraisable exception.Cause
In
Modules/_ctypes/callbacks.c::_CallPythonObject, the callback return value is written into the C result buffer via:Unlike argument handling—which uses
ConvParam()incallproc.cto unwrapctypesinstances into underlying Python values—this callback return path lacks the unwrapping step. This creates an inconsistency between how arguments and return values are processed.Solution
The fix ensures that
ctypesinstances are unwrapped by accessing their.valueattribute before being passed tosetfunc.Key Improvements:
ctypessimple types are converted to native Python values.setfuncreceives input it can process.Behavior After Fix
Implementation Details
test_ctypesto verify that callbacks can safely return subclassed simplectypestypes.