gh-148398: add type watcher in _CHECK_ATTR_CLASS#148399
Merged
Fidget-Spinner merged 4 commits intopython:mainfrom Apr 12, 2026
Merged
gh-148398: add type watcher in _CHECK_ATTR_CLASS#148399Fidget-Spinner merged 4 commits intopython:mainfrom
_CHECK_ATTR_CLASS#148399Fidget-Spinner merged 4 commits intopython:mainfrom
Conversation
NekoAsakura
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
Member
|
I'm not sure whether this went out in an alpha. If it did you probably need a shorts news entry about fixing a bug. |
Contributor
Author
|
Yes, it's been in since a1. I will write it. |
Python/optimizer_bytecodes.c
Outdated
| } | ||
| else { | ||
| sym_set_const(owner, type); | ||
| PyType_Watch(TYPE_WATCHER_ID, type); |
Contributor
There was a problem hiding this comment.
You don't need to add type watcher if type is immutable.
kumaraditya303
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.