Skip to content

gh-148222 Fix Null dereference bugs at genericaliasobject.c#148226

Merged
JelleZijlstra merged 14 commits intopython:mainfrom
prakashsellathurai:fix/148222
Apr 18, 2026
Merged

gh-148222 Fix Null dereference bugs at genericaliasobject.c#148226
JelleZijlstra merged 14 commits intopython:mainfrom
prakashsellathurai:fix/148222

Conversation

@prakashsellathurai
Copy link
Copy Markdown
Contributor

@prakashsellathurai prakashsellathurai commented Apr 7, 2026 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 7, 2026
Closed
JelleZijlstra
JelleZijlstra reviewed Apr 7, 2026
View reviewed changes
Comment thread Objects/genericaliasobject.c Outdated
JelleZijlstra
JelleZijlstra reviewed Apr 7, 2026
View reviewed changes
Comment thread Objects/genericaliasobject.c Outdated
serhiy-storchaka
serhiy-storchaka reviewed Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to write a test for the vectorcall part?

Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-04-07-20-37-23.gh-issue-148222.uF4D4E.rst Outdated
serhiy-storchaka
serhiy-storchaka reviewed Apr 13, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-04-07-20-37-23.gh-issue-148222.uF4D4E.rst Outdated
@prakashsellathurai
Copy link
Copy Markdown
Contributor Author

prakashsellathurai commented Apr 14, 2026 •
edited
Loading

Is it possible to write a test for the vectorcall part?
@serhiy-storchaka

I spent some time on this. since this bug occurs at C implementations level, we cannot reproduce in python unit tests.

also with custom _testcapi extension i am not ably to reliably simulate that exact flow

serhiy-storchaka
serhiy-storchaka approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@prakashsellathurai
Copy link
Copy Markdown
Contributor Author

prakashsellathurai commented Apr 17, 2026

@serhiy-storchaka thanks for the pr review.

all checks are passing. Since I don't have merge access, could you please merge this when you get a chance? Thank you!

@JelleZijlstra JelleZijlstra added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Apr 18, 2026
@JelleZijlstra JelleZijlstra merged commit 634568d into python:main Apr 18, 2026
62 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Apr 18, 2026

Thanks @prakashsellathurai for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 18, 2026
@prakashsellathurai @miss-islington
pythongh-148222: Fix NULL dereference bugs in genericaliasobject.c (p…
559c63c 
…ythonGH-148226)

(cherry picked from commit 634568d)

Co-authored-by: Prakash Sellathurai <prakashsellathurai@gmail.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 18, 2026

GH-148705 is a backport of this pull request to the 3.14 branch.

@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Apr 18, 2026

Sorry, @prakashsellathurai and @JelleZijlstra, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 634568d030f18183212c01bd4544aa7f97e05442 3.13

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Apr 18, 2026
@JelleZijlstra
Copy link
Copy Markdown
Member

JelleZijlstra commented Apr 18, 2026

Would you mind checking if the bug is also present on the 3.13 branch and backport it to 3.13 if so?

JelleZijlstra pushed a commit that referenced this pull request Apr 18, 2026
@miss-islington @prakashsellathurai
[3.14] gh-148222: Fix NULL dereference bugs in genericaliasobject.c (G…
67100b3 
…H-148226) (#148705)

gh-148222: Fix NULL dereference bugs in genericaliasobject.c (GH-148226)
(cherry picked from commit 634568d)

Co-authored-by: Prakash Sellathurai <prakashsellathurai@gmail.com>
prakashsellathurai added a commit to prakashsellathurai/cpython that referenced this pull request Apr 18, 2026
@prakashsellathurai
pythongh-148222: Fix NULL dereference bugs in genericaliasobject.c (p…
6a8f75a 
…ython#148226)

(cherry picked from commit 634568d)
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 18, 2026

GH-148712 is a backport of this pull request to the 3.14 branch.

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 18, 2026

GH-148712 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 18, 2026
prakashsellathurai added a commit to prakashsellathurai/cpython that referenced this pull request Apr 18, 2026
@prakashsellathurai
[3.13] pythongh-148222: Fix NULL dereference bugs in genericaliasobje…
83552a6 
…ct.c (python#148226)

(cherry picked from commit 634568d)
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 18, 2026

GH-148717 is a backport of this pull request to the 3.13 branch.

@prakashsellathurai
Copy link
Copy Markdown
Contributor Author

prakashsellathurai commented Apr 18, 2026

Would you mind checking if the bug is also present on the 3.13 branch and backport it to 3.13 if so?

@JelleZijlstra raised backport to 3.13 in #148717

prakashsellathurai added a commit to prakashsellathurai/cpython that referenced this pull request Apr 18, 2026
@prakashsellathurai
Revert "[3.13] pythongh-148222: Fix NULL dereference bugs in generica…
6690865 
…liasobject.c (python#148226)"

This reverts commit 83552a6.
prakashsellathurai added a commit to prakashsellathurai/cpython that referenced this pull request Apr 18, 2026
@prakashsellathurai
[3.13] pythongh-148222: Fix NULL dereference bugs in genericaliasobje…
7aca63f 
…ct.c (python#148226)

(cherry picked from commit 634568d)
JelleZijlstra pushed a commit that referenced this pull request Apr 18, 2026
@prakashsellathurai
[3.13] gh-148222: Fix NULL dereference bugs in genericaliasobject.c (G…
0ca5390 
…H-148226) (#148717)

(cherry picked from commit 634568d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prakashsellathurai @JelleZijlstra @serhiy-storchaka