Skip to content

gh-146169: correctly handle re-entrant parsing calls in Expat handlers#146566

Open
picnixz wants to merge 7 commits intopython:mainfrom
picnixz:fix/expat/parse-recursive-146169
Open

gh-146169: correctly handle re-entrant parsing calls in Expat handlers#146566
picnixz wants to merge 7 commits intopython:mainfrom
picnixz:fix/expat/parse-recursive-146169

Conversation

@picnixz
Copy link
Copy Markdown
Member

@picnixz picnixz commented Mar 28, 2026

@picnixz
Copy link
Copy Markdown
Member Author

picnixz commented Mar 28, 2026

@hartwork I'd like your feedback here to know whether there are other places that I need to consider. I will work on the encoding issue described in the GH issue afterwards unless they are interconnected. TiA!

@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 28, 2026
Copy link
Copy Markdown
Contributor

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hartwork I'd like your feedback here to know whether there are other places that I need to consider. I will work on the encoding issue described in the GH issue afterwards unless they are interconnected. TiA!

@picnixz they seem interconnected, yes. Here's what I found:

@picnixz
Copy link
Copy Markdown
Member Author

picnixz commented Apr 11, 2026

For the encoding issue, I will actually do it in a separate PR. It's not really a re-entrancy call issue, but rather an issue where you call XML_Parse() first and then you recall it later with a different string and hence have a different possible encoding.

@picnixz picnixz requested a review from hartwork April 11, 2026 13:48
@picnixz picnixz requested a review from hartwork April 12, 2026 16:00
Copy link
Copy Markdown
Contributor

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@picnixz probably good to merge by now(, I lack permissions to approve).

@picnixz
Copy link
Copy Markdown
Member Author

picnixz commented Apr 12, 2026

Thanks! I've left my dev session so I'll merge it tomorrow. Thanks for the review! I'll also address the encoding issue separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants